search

WenheLI / p5.gif

P5.js gif helper
MIT License
38 stars 4 forks source link

Wrong id selector #13

Closed infusion closed 5 years ago

infusion commented 5 years ago

Hello,

in the capture constructor, you call the following:

this.settings.canvas = document.getElementById(`#${this.settings.canvas}`) || window.canvas;

getElementById does not allow to select with leading "#" - this is querySelector syntax. This means it always uses the window.canvas fallback.

Robert

WenheLI commented 5 years ago

You are right! I will fix it asap!

WenheLI commented 5 years ago

Fix by 27da75cc176fc667b07490b8944691b61259c566