search

WenjieWu-Sci / FLArE

Simulation code for R&D of the FLArE detector
2 stars 0 forks source link

4 adding a magnetic field #14

Closed mvicenzi closed 1 year ago

mvicenzi commented 1 year ago

This PR includes:

This can potentially already be merged.

mvicenzi commented 1 year ago
  1. Yes, that's fine for me! I sometimes tab without thinking, I'll try to force myself to stick to 2-spaces.
  2. Of course. I did some preliminary validation using an event display. Just saving all particle hits in output and displaying them. I attach a few picture as proof :) The G4 geometry visualization is instead here. 1 GeV muon, starting at z = 3m (check on first magnetic field) muon1GeV_start3m 5 GeV muon, starting at z = 30m (check on second magnetic field) muon5GeV_start30m 10 GeV muon, starting at z = 3 m (it missing the second field, but it is seen by the first tracking stations) muon10GeV_start3m
  3. I agree. I was planning to focus on a reconstruction strategy next, so I'll be thinking about that. We can potentially wait to merge, but since there is already a lot of new code it might be good to merge this first.
WenjieWu-Sci commented 1 year ago

They look great :+1:. I'll merge this pull request.