WennDann / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

SUMMARY #7

Open griffinlacek opened 7 years ago

griffinlacek commented 7 years ago

Grade: Exceeds Expectations

Summary: This project is great! It meets the spec and goes above and beyond as well. The code is clean and mostly free of errors. Only area of improvement to note is to consider looking into changing some class/id names to follow camelCase or -/_ naming conventions. Also, make sure to include a viewport tag so your styles appear on mobile devices!

As a challenge, a great exercise would be expanding the site with links to the other pages, making minor style tweaks to these pages (the importance here is just getting to practice building multi-page sites). This will give you experience with building and managing a multi-page website.

Good work!

WennDann commented 7 years ago

@griffinlacek Thank you very much for this review. Really happy about the grade of course, but also very thankful for all your comments. They are very welcome and I'll include the ideas in my future projects. The challenge of a multi-page website is actually something I'd had expected as final project. But I can see that this would mean way more review work for all you guys. How many participants did you actually have overall, if I may ask? Best regards from :switzerland: :smile: