WennDann / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Add comments to css and html #3

Open sangjunp4rk opened 7 years ago

sangjunp4rk commented 7 years ago

Try adding comments to your css page. Unlike html, css code is not naturally defined by its structure. So having comments helps you organize it and quickly navigate it. As a suggestion, add comments at the start of each section of the corresponding html code so readers can follow clearly between the two files.

https://github.com/WennDann/prj-rev-bwfs-dasmoto/blob/master/DasmotosArtsCrafts/resources/css/style.css#L1

WennDann commented 7 years ago

@sangjunp4rk Hm, I actually had a structure in mind, but not the one following the flow of the corresponding html document. I rather tried to group tags of the same "level" together. So I go first for the tags, starting with html then h1 -> h6, continuing with classes and finally id's. To me it looked easier to reuse the same css code for other pages, where the html document might have a completely different structure. There I could easily review the css I created and simply remove code I wouldn't need instead of moving it around in the file. But I just started with this, so please let me know what you think is better. Many thanks