Wensber / TextTheSpire

18 stars 4 forks source link

Punctuation for path command output #14

Closed Neurrone closed 4 years ago

Neurrone commented 4 years ago

Hi,

It would be much easier to digest if this output:

Elite 3 Rest 1 Shop 1 Unknown 1 Monster 2 
Elite 6 2 Monster 7 1 Rest 8 0 Treasure 9 0 Elite 10 0 Shop 11 1 Monster 12 1 Unknown 13 0 Elite 14 1 

Had commas inserted so that it looks like this:

Elite 3, Rest 1, Shop 1, Unknown 1, Monster 2 
Elite 6 2, Monster 7 1, Rest 8 0, Treasure 9 0, Elite 10 0, Shop 11 1, Monster 12 1, Unknown 13 0, Elite 14 1 

The extra commas causes a screen reader to pause slightly which makes this large chunk of text much much easier to digest.

Wensber commented 4 years ago

Hello,

I see. That makes sense. I'll add it in the next update.

Thanks, Wensber

On Wed, Jul 15, 2020 at 5:41 AM Dickson Tan notifications@github.com wrote:

Hi,

It would be much easier to digest if this output:

Elite 3 Rest 1 Shop 1 Unknown 1 Monster 2 Elite 6 2 Monster 7 1 Rest 8 0 Treasure 9 0 Elite 10 0 Shop 11 1 Monster 12 1 Unknown 13 0 Elite 14 1

Had commas inserted so that it looks like this:

Elite 3, Rest 1, Shop 1, Unknown 1, Monster 2 Elite 6 2, Monster 7 1, Rest 8 0, Treasure 9 0, Elite 10 0, Shop 11 1, Monster 12 1, Unknown 13 0, Elite 14 1

The extra commas causes a screen reader to pause slightly which makes this large chunk of text much much easier to digest.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Wensber/TextTheSpire/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONINOBMN4RSEC46NZVQ37TR3WPYJANCNFSM4O2P4DQQ .

Neurrone commented 4 years ago

Thanks, this works great in V1.7. Closing.