search

Wensber / TextTheSpire

18 stars 4 forks source link

Help is not shown when querying help about windows #24

Closed sukiletxe closed 3 years ago

sukiletxe commented 3 years ago

I cannot get help for window commands (deck, discard, etc.). Weirdly I took a look at the code and everything seems fine. The rest of the commands (tried with potion, path, ascension and lang) work fine. I tried debugging mts and failed spetacularly.

Wensber commented 3 years ago

Hello,

Found the issue. It was a problem with the json file I had the help text in. The root of the problem was the fact that all commands are set to lowercase. In the json file the keys for the windows had an uppercase letter. I changed it to all lowercase so it should work fine now.

Wensber

On Wed, Mar 3, 2021 at 11:40 AM Sukil Etxenike notifications@github.com wrote:

I cannot get help for window commands (deck, discard, etc.). Weirdly I took a look at the code and everything seems fine. The rest of the commands (tried with potion, path, ascension and lang) work fine. I tried debugging mts and failed spetacularly.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Wensber/TextTheSpire/issues/24, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONINOHWPRASEOMBJOT7YX3TB2GEFANCNFSM4YR3KSRQ .

sukiletxe commented 3 years ago

Will test when the new version is out. Weirdly, before creating the issue, I looked at that file, tried typing the commands the same way they were writen in the json and still didn't work.

Wensber commented 3 years ago

That makes sense. The file had the keys with a capital letter. For example "Deck". You input "help Deck" but it gets set to lowercase before being parsed as a command so it becomes "help deck". Thus it was never able to match with the window commands as they all had a capital letter. I changed the keys to be all lowercase.

On Fri, Mar 5, 2021 at 12:39 AM Sukil Etxenike notifications@github.com wrote:

Will test when the new version is out. Weirdly, before creating the issue, I looked at that file, tried typing the commands the same way they were writen in the json and still didn't work.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Wensber/TextTheSpire/issues/24#issuecomment-791259967, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONINOE5LNS6KRFG4TYNNUTTCCKFNANCNFSM4YR3KSRQ .

sukiletxe commented 3 years ago

Oh I see, thanks!