search

Wenzel / docker-kdesrc-build

Dockerfiles to compile KDE source code into Docker with kdesrc-build script
GNU General Public License v2.0
47 stars 21 forks source link

Explain under which tag the images are uploaded #18

Open krichter722 opened 6 years ago

krichter722 commented 6 years ago

Assuming that you do upload images to hub.docker.com with docker push, it'd be nice to see the info in one of the first sentences of README.md - I read through it and didn't find it, maybe I missed it, but then it's pretty hidden.

If you don't publish images, that information would be appreciated on top of README.md as well.

Another which is not worth a separate issue: you can re-trigger the build of master's HEAD in Travis since it seems to work meanwhile (hit the Travis timeout of 50 minutes, though, so that the status will change from error to failed).

Wenzel commented 6 years ago

Hi, i never thought about uploading the images to Docker hub. It could be an interesting idea though.

I haven't been involved in KDE development since a while, so i don't know how the tools have evolved since. Is my docker wrapper still relevant today ? What do you think ?

t'd be nice to see the info in one of the first sentences of README.md

What kind of information are you talking about, can you explain a bit ?

Thank you for your interest in this project !

krichter722 commented 6 years ago

Is my docker wrapper still relevant today ?

I discovered craft only shortly after opening the issue and PR which might be intended as successor of kdesrc-build (like BuildStream replaced jhbuild in the GNOME project - no idea why the world needs two meta build systems). It works poorly, though because like many project KDE uses Jenkins CI without Docker so that they're basically testing that the build works on their Jenkinks server, but not in a reliably way (it's extremely hard to explain this to people because they've used it for years and think it's working). Therefore any Docker based attempt to build a project like this one makes a lot more sense since there should be an easy portable way to test the current HEAD version of a software in order to improve issue report quality.

t'd be nice to see the info in one of the first sentences of README.md

What kind of information are you talking about, can you explain a bit ?

I meant the information that you don't publish the image on hub.docker.com.

That being said, I'll wait until the issues I filed against craft clear and get back to you (same applies to #19).

Wenzel commented 6 years ago

Thanks for letting me discover craft.

It doesn't look like container based though, so yeah, you "pollute" your system with development packages, and it's distro dependent.

How do you think we could advertise docker-kdesrc-build a bit more to the KDE community ? It has been around since 5 years, but the community isn't aware of it.

krichter722 commented 6 years ago

How do you think we could advertise docker-kdesrc-build a bit more to the KDE community ? It has been around since 5 years, but the community isn't aware of it.

I'd clarify whether craft is supposed to be the successor of kdesrc-build first. If yes, then they'll drop support for kdesrc-build (and even if that makes kdesrc-build and docker-kdesrc-build obsolete it's a better step than keeping both maintained). If you ask, you may include the question why the produced craft if there's BuildStream (I'm pretty sure that BuildStream is way more popular, portable and older). I'd be interested in the link (probably to the mailing list archive or whatever newer/better forms of communication you use).

Wenzel commented 6 years ago

I won't have the time to engage in these discussions on the mailing list in a near future. Please do so if you can.

Thank you.