search

Weppu / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Summary #5

Open robynmaya opened 6 years ago

robynmaya commented 6 years ago

Grade : Needs Improvement.

You did a good job. But unfortunately, your work can not be properly graded due to the missing stylesheet file.

I would like to also recommend you to :

  1. Include a complete set of Meta tags in your <head></head> element

  2. Make sure your CSS is written and organized in a top-down format and including comments to mark sections, like so : 

/* Universal classes */ 
(body, a, p, h1, etc.)

/* Header */
#header

/* Navigation */ 
#nav-menu

/* Main Content */
#main-content

  1. Explore the use of HTML5 Semantic Elements (certain types of websites are always appropriate to be structured using HTML5 semantic elements, such as Blogs, Company/Organization Website, Static Website). Read More.

  2. Try to always adhere to the naming convention for your IDs and Classes. Read more

Weppu commented 6 years ago

Hey Maya

Thanks for the reviewing this project and for providing valuable feedback.

It really is unfortunate that I did not manage to commit the CSS file for some reason :/

Should I commit it for you to review later, or just be more attentive/careful next time?

Thank you for the helpful links :)