search

WerWolv / Hekate-Toolbox

A toolbox for Hekate
GNU General Public License v3.0
213 stars 24 forks source link

Fix keyCharsToKey #8

Closed 16BitWonder closed 5 years ago

16BitWonder commented 5 years ago

keyCharsToKey currently takes the substring of the current key value regardless if '!' is present.

So if your current string is "R" it will change to "" before the function can identify the key. Resulting in the key not being recognized/displayed in the app on startup.

Additionally if the user then changes the "Open Album by default" to on or off before picking a key, loader will result in values like: "override_key=" or "override_key=!"

I re-used *overrideByDefault as the condition since that would have already been set by the time the if is called, though (str[0] == '!') should work the same if you'd rather use that for the condition.

ghost commented 5 years ago

But WerWolv mentioned both were fixed https://github.com/AtlasNX/Kosmos-Toolbox/issues/7

WerWolv commented 5 years ago

Seriously I'm bad with version management. I fixed that like 3 times already xD I'll fix this in my local copy and close this PR if that's okay. Thanks for letting me know again!