Closed sisco0 closed 3 months ago
Thanks a lot!
Is it important that the values of the padding fields are shown? padding
is a special keyword otherwise that simply skips those bits without them being shown in the pattern data view.
Thank you for your kind review @WerWolv .
I have now re-worked the current Pull Request with proper values after consulting GIMP repository.
Only one padding is left, and that is presented at the end of the current bitfield with the name padding
for not showing it.
I would re-factor the current Pull Request to contain a test, so ideally I could learn more from the repository structure and could provide evidence.
There's already a test file in the repo that the current pattern is being run on to make sure it runs correctly. But you can add some std::assert()
calls to the pattern file to verify values if there's any good candidates
Solves https://github.com/WerWolv/ImHex/issues/1744
Pattern
PixelFormatFlags
, which is part ofDDS_PIXELFORMAT
is an already present bitfield which requires of re-work. The following actions were performed over the given bitfield:luminance
field is now properly aligned.For more information about the current re-worked bitfield, consult Direct-Draw Surface flags definition at GIMP.
Checklist
#pragma description My pattern Description here
)#pragma MIME mime-type
in the source code)application/octet-stream
here as that means "Unidentifiable binary data"