WerWolv / ImHex-Patterns

Hex patterns, include patterns and magic files for the use with the ImHex Hex Editor
https://github.com/WerWolv/ImHex
GNU General Public License v2.0
640 stars 168 forks source link

patterns: Added Kaydara FBX Binary format #271

Closed Hikodroid closed 1 month ago

Hikodroid commented 1 month ago

This hexpat parses a binary FBX file to give a high-level overview of its contents.

Hikodroid commented 1 month ago

Fixed a bug and added support for decompressing arrays. The pattern should be feature-complete now.

C3pa commented 1 month ago

Why did you decide to close the PR? WevWolv might have just missed it.

WerWolv commented 1 month ago

Might have been a mistake yeah. I'm absolutely open for merging this

WerWolv commented 1 month ago

Ah the original repo was deleted. I'll just merge it manually then. Thanks a lot for the effort!

Hikodroid commented 1 month ago

nestedList seems to have some issues that I could not fix. I discovered late that the pattern fails to cover some FBX files entirely and I have not been able to find the cause of it, but it seems to be related to the way I handled NodeRecord subtrees. Therefore I closed the PR because I did not want to submit something that is broken. Sorry for the confusion.