search

WerWolv / ImHex-Patterns

Hex patterns, include patterns and magic files for the use with the ImHex Hex Editor
https://github.com/WerWolv/ImHex
GNU General Public License v2.0
640 stars 168 forks source link

patterns: FBX - fixed the fbx hexpat #276

Closed Hikodroid closed 1 month ago

Hikodroid commented 1 month ago

I split the fix and some improvements into two separate commits. Both should be functionally the same and I would have expected both to be fully working but the first commit does not work and the second one does. I'm not sure why my weird workaround actually works but it should be in a useful state now.

Hikodroid commented 1 month ago

Strange, the unit test is failing with runtime error: Cannot call unknown function 'builtin::hex::dec::zlib_decompress'. Do I need to remove the decompressed sections?

WerWolv commented 1 month ago

It's not working in the CI because it's an ImHex extension, it's not available outside of it. This is actually the first pattern that makes use of functions like this that's on the repo. I don't think it should be removed but I need to think of a way to make it still work here too. Maybe with an #ifdef or something. I'll take care of that though, nothing for you to worry about