WerWolv / ImHex

🔍 A Hex Editor for Reverse Engineers, Programmers and people who value their retinas when working at 3 AM.
https://imhex.werwolv.net
GNU General Public License v2.0
42.7k stars 1.88k forks source link

[Bug] Shortcut to save project has no effect when editing pattern data #1198

Open AlexXsWx opened 1 year ago

AlexXsWx commented 1 year ago

Operating System

Windows

What's the issue you encountered?

Pressing Alt+S (Save project shortcut, according to File > Project > Save Project menu) while "Pattern editor" tab is in focus has no effect

How can the issue be reproduced?

  1. Launch ImHex
  2. Drag-n-drop any file
  3. Write anything in the "Pattern editor" tab
  4. Note how tab with the file name has a circle on the right side, indicating unsaved changes
  5. File > Project > Save Project As; proceed with saving the project.
  6. Note the unsaved changes indicator disappearing
  7. Make any text edit in the "Pattern editor" tab
  8. Note the unsaved changes indicator appearing again
  9. Press Alt+S

Expected result: Project is saved, unsaved changes indicator disappearing

Actual result: Project is not saved, unsaved changes indicator remains present

ImHex Version

1.30.1

ImHex Build Type

Installation type

Portable

Additional context?

Windows 7. One other person confirmed Alt+S not working when pattern editor is in focus on Windows 10.

LennardF1989 commented 1 year ago

I'd say ALT+S (but maybe even CTRL+S) should work from anywhere (whichever you have focussed), not just the pattern editor.

paxcut commented 1 year ago

the only places where it doesn't work are the pattern editor and the console because they use a separate set of shortcuts than the rest of imgui. i still think that saving the pattern file should be available when pattern editor has focus.

paxcut commented 1 month ago

Alt-S was added to the pattern editor set of shortcuts a while back and it does save the current project.Also save as shortcut was added (can't remember the key now ) so if you can test maybe this issue can be closed?