search

WerWolv / ImHex

🔍 A Hex Editor for Reverse Engineers, Programmers and people who value their retinas when working at 3 AM.
https://imhex.werwolv.net
GNU General Public License v2.0
42.72k stars 1.88k forks source link

[Bug] "Remove" button in Content Store doesn't do the job [MacOS] #1224

Closed ershov closed 5 days ago

ershov commented 1 year ago

Operating System

MacOS

What's the issue you encountered?

In Content Store there button "Remove" doesn't actually remove the thing.

How can the issue be reproduced?

  1. Make a fresh installation of ImHex.
  2. In "Content Store" download the "Standard Magic" by "Download" button.
  3. "Remove" button appears.
  4. Press the "Remove" button.

The downloaded files are still there and "standard magic" works.

ImHex Version

1.30.1

ImHex Build Type

Installation type

DMG

Additional context?

No response

paxcut commented 1 year ago

I tested this on windows using latest nightly portable and when i delete pe magic the file is no longer in the magic folder of portable

iTrooz commented 1 year ago

I can reproduce this bug, the other files get removed, but the *.mgc files stay there

paxcut commented 1 year ago

I deleted standard magic and there was no trace left of anything that was downloaded when I first installed it. Maybe thats only for standard magic.

iTrooz commented 1 year ago

I just talking with WerWolv, and apparently its only an issue for Linux (and MacOS I guess)

In short, libmagic isn't consistent across platforms, and our hack (https://github.com/WerWolv/ImHex/pull/1212) to resolve this doesn't put the .mgc files where it should (they should be in the standard_magic folder)

paxcut commented 1 year ago

I guess I dont quite understand the implications with respect to this issue. I just tested and for the other two magic files there are both a .magic and a .mgc and they are both on the magic folder. Deleting either on on the content store deletes only the .magic file on windows. Is this part of the bug or should these two also have their own folders? When I install standard magic it creates a standard_magic folder where a lot of mgc and extensionless files are written. Is the bug then only that on linux this folder is never created?

ershov commented 1 year ago

On MacOS, it doesn't create a standard_magic subdirectory - the files are all in the magic dir.

ershov commented 1 year ago

I honestly don't think it's a high priority bug. I hardly can imagine why anyone would delete anything.

github-actions[bot] commented 1 month ago

This issue is marked stale as it has been open for 11 months without activity. Please try the latest ImHex version. (Avaiable here: https://imhex.download/ for release and https://imhex.download/#nightly for development version) If the issue persists on the latest version, please make a comment on this issue again

Without response, this issue will be closed in one month.