search

WerWolv / ImHex

🔍 A Hex Editor for Reverse Engineers, Programmers and people who value their retinas when working at 3 AM.
https://imhex.werwolv.net
GNU General Public License v2.0
40.06k stars 1.76k forks source link

impr: Add a link to the "Find" view in the search popup #1665

Closed SparkyTD closed 1 month ago

SparkyTD commented 1 month ago

Problem description

This PR adds a shortcut link on the Search (Ctrl+F) popup to the more advanced "Find" view that is normally accessible at the View > Find menu.

Implementation description

I added a simple ImGuiExt::IconHyperlink link to the draw() function of the PopupFind class to display the hyperlink. Clicking the link will open the Find view, bring it into focus and close the current popup.

Screenshots

Before: image

After: image

Additional things

SparkyTD commented 1 month ago

Should I try to AI-translate the rest of the localizations before we merge?

WerWolv commented 1 month ago

Thank you!

Should I try to AI-translate the rest of the localizations before we merge?

No, please only fill in the languages that you know yourself and leave the rest for dedicated translators that know the language. That way we can ensure that the translations actually are meaningful. I rather have a program with no translation for my native language than one with a comically wrong one ^^