WerWolv / ImHex

🔍 A Hex Editor for Reverse Engineers, Programmers and people who value their retinas when working at 3 AM.
https://imhex.werwolv.net
GNU General Public License v2.0
43.96k stars 1.92k forks source link

[Bug] Search panel's misleading information on search new pattern #1677

Open mehlian opened 4 months ago

mehlian commented 4 months ago

Operating System

Windows

What's the issue you encountered?

When you search for items in 'Hex editor' view using 'search panel' (ctrl+f) misleading 'No more results' information may appear.

How can the issue be reproduced?

  1. open any file with unique bytes patterns
  2. open 'search panel' using ctrl+f and search for hex values that are stored in the middle of the file and press enter to highlight/select that pattern
  3. while 'search panel' is still open change searching hex values to those that appear before those in the middle of file (first we searching for hex that is only in the middle of file, then we search for hex that is only at start of file)
  4. 'search panel' informs us that there are 'No more results' but instead it should found new pattern.

ImHex Version

1.33.0

ImHex Build Type

Installation type

Portable

Additional context?

This issue occurs because on value change in 'search panel' we do not search from beginning of the file but where we last stopped.