[Feature] Bookmarks: Change order of bookmarks

WerWolv / ImHex

🔍 A Hex Editor for Reverse Engineers, Programmers and people who value their retinas when working at 3 AM.

https://imhex.werwolv.net

GNU General Public License v2.0

37.42k stars 1.64k forks source link

[Feature] Bookmarks: Change order of bookmarks #1745

Closed Murmele closed 3 weeks ago

Murmele commented 3 weeks ago

What feature would you like to see?

When having overlaping bookmarks only the upper bookmark is visualized. It would be nice if it is possible to change the order so that another bookmark is the priorized one.

How will this feature be useful to you and others?

Otherwise the two bookmarks are only visible if the byte gets hovered.

Request Type

[ ] I can provide a PoC for this feature or am willing to work on it myself and submit a PR

Additional context?

No response

Murmele commented 3 weeks ago

@WerWolv thanks for the fast fix :) Maybe instead of swapping just putting it before that other bookmark? I hacked a little bit in the code, but before I was able to create a pullrequest you are already finished ^^

WerWolv commented 3 weeks ago

No problem. The reason I did it this way is because you can't drop the bookmarks between two bookmarks, only on top of another bookmark which means there would be no way to move an element either to the very top of the list or the very bottom

Murmele commented 3 weeks ago

Yes this is true but you need much more movements to get into the correct order. When not moving to the bottom you need 1 movement. For the bottom you need two movements.

WerWolv commented 3 weeks ago

Played around with it a bunch more now and managed to partially emulate it. Hope it's good enough

Murmele commented 3 weeks ago

Thank you very much, I tested it and this is amazing :D