WerewolfCustoms / ModsStudio2IssueBoard

Task board and bug tracker for Mods Studio 2 project
10 stars 1 forks source link

Icon displays and replaces truck in "Truck Browser" #262

Open DannyKay321 opened 1 year ago

DannyKay321 commented 1 year ago

Describe the bug Skin icon displays and replaces trucks in "Truck Browser"

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Content Browsers'
  2. Click on 'Truck Browser > Truck Design' MS2 Version: v.2022.1 ets2_20221110_094439_00
pete-agreatguy commented 1 year ago

Did you have any mods installed and active on this profile, other than your skin mod?

DannyKay321 commented 1 year ago

This is a test profile so nothing other than the skin.

pete-agreatguy commented 1 year ago

We'll look into this :) thanks for using the proper report process.

DannyKay321 commented 1 year ago

Ok no problem, I've tested 4 skin packs and 2 out of 4 does it, All skins packs are made the same and after double checking the only difference i can see is the two that are doing it have Krone skins and the two that aren't don't have Krone skins. If you want the two skin packs then its not a problem because they are public anyway, Unsure if that will help or not knowing they are the ones that are doing it.

pete-agreatguy commented 1 year ago

If you could, please link the steam workshop urls here for them :)

If you right click on the mod steam page, you'll see a copy page url option :)

DannyKay321 commented 1 year ago

https://steamcommunity.com/sharedfiles/filedetails/?id=2638223502 https://steamcommunity.com/sharedfiles/filedetails/?id=2609302362

Mike7O commented 1 year ago

To Reproduce Steps to reproduce the behavior:

  1. Don't USE a unique name ...use SCS default 😎

It's been on the discord a few times ... use of unique names is a must .... but I understand that could be a lot of work doing packages, easier to just re-use and get on with it 😉

MS2 partially responsible (NOT really) ...to the extend of using the same filedirectoy for these custom mods...

most skins/ well all of them I could say use the same path, which is a reason to USE unique names....not to be overwritten or overwrite existing ones.... other modders or even SCS default textures.

material/ui/accessory - the default filepath for any of the projects made .... if users Do create their unique internal filenames adding a prefixfolder would solve this issue. Still the naming of mods are important...never re-use a name...only use once 😎

material/ui/accessory/ms2/

for example editing projectfiles within every template:

`# Mods Studio 2 mod template: Advanced truck skin (NextGen)

name:                   "{{SkinName}}"
price:                  {{SkinPrice}}
unlock:                 {{SkinUnlock}}

icon: "ms2/{{InternalName}}"

airbrush:               {{!EnableMask}}
base_color_locked:      {{BaseColorLocked}}
base_color:             {{BaseColor}}
alternate_uvset:        {{AlternateUvSet}}`

for Danny, I took some screenshots to show you the reason ...your linked mods... which if either of them are in highest modpriority would overwrite the other ones images.... as they share the same internal names - and also uses the SCS defaultnames ... with the existing filepath without the prefixfolder would overwrite those images aswell.

(marked some stuff on the images that wasn't comparable between these two mods...just same name I saw in another skinmod so would be a conflict with that one aswell)

github-1-materialuiaccessory-default_conflicts github-2-materialuiaccessory-default_conflicts

as you see above ... same same ... but different mods basegame below: github-3-materialuiaccessory-default_conflicts

DannyKay321 commented 1 year ago

Thanks damn i now get why i normally have unique names but on these two specific skin packs it seems i haven't for some reason therefore I'm currently changing it.

pete-agreatguy commented 1 year ago

@Mike7O , Would the following (issue #255 ) fix the above or does this require code changes in the template files?