Closed CrowdfordBot closed 11 months ago
captainluffy: also, maybe we can change riding hood so that it blocks wolfpack poll and also roleblocks its killer, even if it was killed by wolfpack poll (instead of only blocking its killer if it wasnt killed by wolfpack). That just removes a few conditionals to make it slightly more consistent and streamlined
mctsts: makes sense
captainluffy:
also, maybe we can change riding hood so that it blocks wolfpack poll and also roleblocks its killer, even if it was killed by wolfpack poll (instead of only blocking its killer if it wasnt killed by wolfpack). That just removes a few conditionals to make it slightly more consistent and streamlined
<@458727748504911884> do u have any opinions on this?
shapechange: mm okay wait
shapechange: are you just making sure the technical terms are used here?
shapechange: or are you actually making it so that rh rbs pack AND nonpack
shapechange: instead of poll manipping pack and rbing nonpack
captainluffy: The main reason it matters is a weird interaction with the proposed changes to direwolf, where its extra kill is a personal kill.
So if it uses its personal kill, it's roleblocked and can't use the poll kill or personal
If it kills with the poll, only the poll is removed and it keeps the personal kill
shapechange: alright i need to do a rewrite of that desc huh
shapechange: ill look at the ability types in general at some point
captainluffy:
or are you actually making it so that rh rbs pack AND nonpack
Proposed change: It always blocks it killer (if wolfish) regardless of pack kill or not
Keeps: if it was a pack kill, remove the poll next night
shapechange: okay i think i get it
shapechange: yeah that seems fine
shapechange:
we should maybe consider renaming role blocking to ability blocking
captainluffy: Ok, should I make a pr or is more discussion required
shapechange: i think since this functionally changes very little you can just make a pr
captainluffy: https://github.com/McTsts/Werewolves-Roles/pull/1235
captainluffy: oh i should probably say "day and night" instead of "night and day"
mctsts:
we should maybe consider renaming role blocking to ability blocking
good point
captainluffy: its called roleblocking in most mafia servers so its a well understood term
captainluffy: but ability blocking makes more sense because it blocks stuff under the ability section
shapechange: i know why it's called roleblocking, but GENERALLY (this is a GENERALISATION) in mafia you can't have multiple roles as default - and yeah, your second point is the major reason
mctsts: made a pr for it
captainluffy: then i would need to change the riding hood word as well
mctsts: oh yea
captainluffy: so in the riding hood pr ill change it too
captainluffy: i think this is good to close
shapechange: dont close it until ive reviewed the pr
mctsts: Merged.
captainluffy: title