WerewolvesRevamped / Werewolves-Roles

The role book for Werewolves Revamped
7 stars 8 forks source link

riding desc should use the term roleblock #1231

Closed CrowdfordBot closed 11 months ago

CrowdfordBot commented 11 months ago

captainluffy: title

CrowdfordBot commented 11 months ago

captainluffy: also, maybe we can change riding hood so that it blocks wolfpack poll and also roleblocks its killer, even if it was killed by wolfpack poll (instead of only blocking its killer if it wasnt killed by wolfpack). That just removes a few conditionals to make it slightly more consistent and streamlined

CrowdfordBot commented 11 months ago

mctsts: makes sense

CrowdfordBot commented 11 months ago

captainluffy:

also, maybe we can change riding hood so that it blocks wolfpack poll and also roleblocks its killer, even if it was killed by wolfpack poll (instead of only blocking its killer if it wasnt killed by wolfpack). That just removes a few conditionals to make it slightly more consistent and streamlined

<@458727748504911884> do u have any opinions on this?

CrowdfordBot commented 11 months ago

shapechange: mm okay wait

CrowdfordBot commented 11 months ago

shapechange: are you just making sure the technical terms are used here?

CrowdfordBot commented 11 months ago

shapechange: or are you actually making it so that rh rbs pack AND nonpack

CrowdfordBot commented 11 months ago

shapechange: instead of poll manipping pack and rbing nonpack

CrowdfordBot commented 11 months ago

captainluffy: The main reason it matters is a weird interaction with the proposed changes to direwolf, where its extra kill is a personal kill.

So if it uses its personal kill, it's roleblocked and can't use the poll kill or personal

If it kills with the poll, only the poll is removed and it keeps the personal kill

CrowdfordBot commented 11 months ago

shapechange: alright i need to do a rewrite of that desc huh

CrowdfordBot commented 11 months ago

shapechange: ill look at the ability types in general at some point

CrowdfordBot commented 11 months ago

captainluffy:

or are you actually making it so that rh rbs pack AND nonpack

Proposed change: It always blocks it killer (if wolfish) regardless of pack kill or not

Keeps: if it was a pack kill, remove the poll next night

CrowdfordBot commented 11 months ago

shapechange: okay i think i get it

CrowdfordBot commented 11 months ago

shapechange: yeah that seems fine

CrowdfordBot commented 11 months ago

shapechange:

we should maybe consider renaming role blocking to ability blocking

CrowdfordBot commented 11 months ago

captainluffy: Ok, should I make a pr or is more discussion required

CrowdfordBot commented 11 months ago

shapechange: i think since this functionally changes very little you can just make a pr

CrowdfordBot commented 11 months ago

captainluffy: https://github.com/McTsts/Werewolves-Roles/pull/1235

CrowdfordBot commented 11 months ago

captainluffy: oh i should probably say "day and night" instead of "night and day"

CrowdfordBot commented 11 months ago

mctsts:

we should maybe consider renaming role blocking to ability blocking

good point

CrowdfordBot commented 11 months ago

mctsts:

https://github.com/McTsts/Werewolves-Roles/pull/1235

seems good, can we merge it?

CrowdfordBot commented 11 months ago

captainluffy: its called roleblocking in most mafia servers so its a well understood term

CrowdfordBot commented 11 months ago

captainluffy: but ability blocking makes more sense because it blocks stuff under the ability section

CrowdfordBot commented 11 months ago

shapechange: i know why it's called roleblocking, but GENERALLY (this is a GENERALISATION) in mafia you can't have multiple roles as default - and yeah, your second point is the major reason

CrowdfordBot commented 11 months ago

mctsts: https://github.com/McTsts/Werewolves-Roles/pull/1236

CrowdfordBot commented 11 months ago

mctsts: made a pr for it

CrowdfordBot commented 11 months ago

captainluffy: then i would need to change the riding hood word as well

CrowdfordBot commented 11 months ago

captainluffy:

https://github.com/McTsts/Werewolves-Roles/pull/1236

need to also change this file

CrowdfordBot commented 11 months ago

mctsts: oh yea

CrowdfordBot commented 11 months ago

captainluffy: so in the riding hood pr ill change it too

CrowdfordBot commented 11 months ago

captainluffy: i think this is good to close

CrowdfordBot commented 11 months ago

shapechange: dont close it until ive reviewed the pr

CrowdfordBot commented 11 months ago

mctsts: Merged.