Clean up hag desc

[CrowdfordBot]

Ts: <@839150186613702749>

[CrowdfordBot]

Ts: <@839150186613702749> based on the thread description I assume you requested this. What improvements are there we need to make?

[CrowdfordBot]

!Phantomtomic: Mostly cautious and bitter hag iirc

[CrowdfordBot]

!Phantomtomic: Though others said that the hag desc is a bit confusing

[CrowdfordBot]

!Phantomtomic: I’ll look into it

[CrowdfordBot]

Ts: 👍

[CrowdfordBot]

Ts: Make sure to check the versions in the v16 branch: https://github.com/McTsts/Werewolves-Roles/tree/v16

[CrowdfordBot]

!Phantomtomic: Oh I think the bh has the buff in its desc

[CrowdfordBot]

Ts: <@839150186613702749> does this still need doing?

[CrowdfordBot]

!Phantomtomic: I forgot about it

[CrowdfordBot]

!Phantomtomic: I'll try to attempt a rewrite tomorrow

[CrowdfordBot]

Ts: epic

[CrowdfordBot]

!Phantomtomic: Putting it here for now (If it isn’t mentioned, it’s remained the same, changes are bolded, this is somewhat a placeholder even though I'm basically done)

Bitter Hag Details When hags become Bitter Hags they gain a new secret channel with the other Bitter Hags (if there are any). Each Bitter Hag may protect, investigate and attack a player every night. However, if their previous spell had any uses left, they do not get to keep these upon changing to Bitter Hag. The spells of the Bitter Hag work like the spells of the cautious, vicious and prophetic hag and are not affected by any disguises, redirections or obstructions. The Bitter Hag cannot be part of role lists and can only be created by a hag turning into it. Sometimes, hags may turn into Bitter Hags directly after wronging (if they are wronged by the last remaining team that hasn't wronged them), however they may also turn into Bitter Hags if the last remaining team that hasn't wronged them is eliminated, leaving only teams that have wronged the hags. The Bitter Hag is strongly disguised as a Hag. Reasoning: I think bitter hag got buffed to every night(?); Grammar

Cautious Hag Details The Cautious Hag is one of the hags ($i hags). During the night, the Cautious Hag may use any number of their spell(s) to protect a player(s). The Cautious Hag may protect themself. This power is not affected by redirections. Protecting a player is an immediate ability. Protected players will be immune to attacks for the rest of the night. If the protected player is a hag, they can also not be affected by any other action that is counted as “wronging” (e.g. Transformations). The Cautious Hag is strongly disguised as a Hag. Reasoning: Used to be that they could only use their spells once per night (which contradicts the hags desc); Cautious hag used to protect solo effects but that’s not a thing so it’s just transformation protection; Consistency; Grammar

[CrowdfordBot]

!Phantomtomic: (I have a feeling the change adds too many (s) and could potentially be confusing so they could be freely removed/changed)

Hag Details The Hag is one of the hags ($i hags). At the start of the game, the Hag may discard one hag role (vicious, cautious or prophetic). At the end of the day, the Hag turns into an undiscarded hag role. The Hag does not have a spell at the start of the game, but gains one later, once they turn into another hag role. Reasoning: People new to hag seem to forget they could discard. Since the host/gamelog action usually has “discard” (iirc), adding the term to the role could make it more clear on what discarding does; Consistency

The Hags Each Hag (with the exception of the plain hag and the cupid hag) has one specific spell that they can use during the night. Hags may only use their spell once, however every time a Hag is wronged they gain an additional use for their spell. Hags are allowed to wait until their spell has several uses and then use it more than once in one night. Reasoning: Just grammar

Prophetic Hag Details The Prophetic Hag is one of the hags ($i hags). During the night, the Prophetic Hag may use any number of their spell(s) to see the current alignment of another player(s). This check is not affected by any disguises, obstructions or redirections. Checking a player is an immediate ability. The Prophetic Hag is strongly disguised as a Hag. Reasoning: Same as before; Consistency; Grammar

Vicious Hag Details The Vicious Hag is one of the hags ($i hags). During the night, the Vicious Hag may use any number of their spell(s) to attack another player(s). This power is not affected by redirections. Attacking a player is an end-night ability. The Vicious Hag is strongly disguised as a Hag. Reasoning: Same as before; Consistency; Grammar

[CrowdfordBot]

Ts:

Putting it here for now (If it isn’t mentioned, it’s remained the same, changes are bolded, this is somewhat a placeholder even though I'm basically done)

Bitter Hag Details When hags become Bitter Hags they gain a new secret channel with the other Bitter Hags (if there are any). Each Bitter Hag may protect, investigate and attack a player every night. However, if their previous spell had any uses left, they do not get to keep these upon changing to Bitter Hag. The spells of the Bitter Hag work like the spells of the cautious, vicious and prophetic hag and are not affected by any disguises, redirections or obstructions. The Bitter Hag cannot be part of role lists and can only be created by a hag turning into it. Sometimes, hags may turn into Bitter Hags directly after wronging (if they are wronged by the last remaining team that hasn't wronged them), however they may also turn into Bitter Hags if the last remaining team that hasn't wronged them is eliminated, leaving only teams that have wronged the hags. The Bitter Hag is strongly disguised as a Hag. Reasoning: I think bitter hag got buffed to every night(?); Grammar

Cautious Hag Details The Cautious Hag is one of the hags ($i hags). During the night, the Cautious Hag may use any number of their spell(s) to protect a player(s). The Cautious Hag may protect themself. This power is not affected by redirections. Protecting a player is an immediate ability. Protected players will be immune to attacks for the rest of the night. If the protected player is a hag, they can also not be affected by any other action that is counted as “wronging” (e.g. Transformations). The Cautious Hag is strongly disguised as a Hag. Reasoning: Used to be that they could only use their spells once per night (which contradicts the hags desc); Cautious hag used to protect solo effects but that’s not a thing so it’s just transformation protection; Consistency; Grammar

Seems good! Can you make it a PR for v16? (https://github.com/McTsts/Werewolves-Roles/tree/v16)

[CrowdfordBot]

!Phantomtomic: How do I make a PR? Do I just press the new pull request button in the pull requests section

[CrowdfordBot]

Ts:

How do I make a PR? Do I just press the new pull request button in the pull requests section

go to a file you want to edit and start editing it, then when saving it select "Create a new branch" (img1) here (make sure you navigate to the file youre editing on the v16 branch, so you branch of v16 and not main. Use my link above). Once youve done that for the first file you can select the new branch in the dropdown (img2) and edit the other files in there (this time you can directly commit to your new branch), then after you've done all the edits you go back to the main page of the repo, it should automatically ask you if you want to make a PR for the new branch there, click that button to make the PR

[CrowdfordBot]

!Phantomtomic: It says I have to fork something before editing, though after that message was gone it let me edit, why is that?

[CrowdfordBot]

!Phantomtomic: I got it to work

[CrowdfordBot]

!Phantomtomic: Do I make a seperate pr for every hag?

[CrowdfordBot]

!Phantomtomic: Because it seems like that's what it's going to do

[CrowdfordBot]

Ts: no

[CrowdfordBot]

!Phantomtomic: oh

[CrowdfordBot]

Ts: It seems you dont have direct permissions to the repo yet

[CrowdfordBot]

Ts: if you dont have access to a repo you cant create a branch directly on it, instead you create a fork

[CrowdfordBot]

Ts: You created a branch on your fork: patch-1 https://github.com/Phantomtomic/Werewolves-Roles/tree/patch-1

[CrowdfordBot]

Ts: you select it in the branch menu / by using my link

[CrowdfordBot]

Ts: you then do the remaining edits directly there (and when editing a file you choose to commit to patch-1 directly)

[CrowdfordBot]

Ts: once you've made all edits to the branch you can create the PR

[CrowdfordBot]

Ts: (or you can retry without the fork now)

[CrowdfordBot]

!Phantomtomic: Alr, I'll do the rest of the editing tomorrow

[CrowdfordBot]

Ts: <@839150186613702749> Did you just want to do BH or are you adding more here? https://github.com/McTsts/Werewolves-Roles/pull/1063/files

[CrowdfordBot]

!Phantomtomic: Oh I'll do it now

[CrowdfordBot]

Ts: 👍