search

WesBosch / brunch-toolkit

Stable release channel for the Brunch Toolkit
GNU Affero General Public License v3.0
88 stars 9 forks source link

FR: Downloads location variable #1

Closed DennisLfromGA closed 3 years ago

DennisLfromGA commented 3 years ago

I know this is a big ask but would there be a chance to make '~/Downloads' a variable?

It could be declared as DOWNLOADS="~/Downloads" and still work for those that keep their brunch releases and recovery images in ~/Downloads. I have been keeping historical releases in /usr/local/brunch-work so with a DOWNLOADS variable I could just redefine it to work on my device instead of copying or moving everything to ~/Downloads.

I may be the only one that doesn't keep their brunch stuff in ~/Downloads so I'll understand if you don't want to do this, just thought I'd ask though.

Thanx, -DennisLfromGA

WesBosch commented 3 years ago

I think it's a good idea actually. It would still be compatible with users as it is while providing more flexibility to more experienced users. It also goes hand in hand with a change I have been mulling over so I'll keep a note of it going forward

On Wed, Oct 14, 2020, 2:22 PM DennisL notifications@github.com wrote:

I know this is a big ask but would there be a chance to make ' ~/Downloads' a variable?

It could be declared as DOWNLOADS="~/Downloads" and still work for those that keep their brunch releases and recovery images in ~/Downloads. I have been keeping historical releases in /usr/local/brunch-work so with a DOWNLOADS variable I could just redefine it to work on my device instead of copying or moving everything to ~/Downloads.

I may be the only one that doesn't keep their brunch stuff in ~/Downloads so I'll understand if you don't want to do this, just thought I'd ask though.

Thanx, -DennisLfromGA

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/WesBosch/brunch-toolkit/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/APHW7HQBVUQJFXKYN2NLDYTSKXT7BANCNFSM4SQ6VK3Q .

DennisLfromGA commented 3 years ago

That's awesome, thanx for your quick response & kind consideration.

WesBosch commented 3 years ago

Alright, I've got a $DOWNLOADS variable working. It's currently set up like this:

DOWNLOADS="$HOME/Downloads"

which appears to work well in my testing. It's near the top of the script for easy changing (line 5) of the script in this zip file I've prepared for you. Would you be able to test this to see if it will work for your uses? If you have any changes or suggestions be sure to let me know

brunch-toolkit-v1.0.2b.zip

DennisLfromGA commented 3 years ago

I'll grab my brunch device today, test it, and get back to you.

Thanx for accommodating this request - and all your efforts.