search

WesCook / Nutrition

A Minecraft mod that ensures you eat healthy.
MIT License
112 stars 39 forks source link

Is malnutrition a negative effect? #259

Closed 19300000 closed 1 year ago

19300000 commented 1 year ago

Why does the potion core module's dispel clear it?

19300000 commented 1 year ago

avaritia module's armor cannot clear it

WesCook commented 1 year ago

Malnourished is indeed a negative effect, and should be classified as such in the game. While double checking that, I was surprised to see that Nourished was not marked as beneficial. I've corrected that, but will likely not create a release for it unless there's something more pressing to include. Setting up Forge's build process is... an ordeal.

As for Potion Core and Avaritia, I can't comment on those mods, but it's expected that they'd be unable to clear a potion effect from Nutrition as they're being constantly reapplied. You need to correct your nutritional deficiency, not just clear away the negative effects.

19300000 commented 1 year ago

Malnourished is indeed a negative effect, and should be classified as such in the game. While double checking that, I was surprised to see that Nourished was not marked as beneficial. I've corrected that, but will likely not create a release for it unless there's something more pressing to include. Setting up Forge's build process is... an ordeal.

As for Potion Core and Avaritia, I can't comment on those mods, but it's expected that they'd be unable to clear a potion effect from Nutrition as they're being constantly reapplied. You need to correct your nutritional deficiency, not just clear away the negative effects.

Well, actually, I was going to make both the dispersal and the malnutrition kick in when the nutrient index reaches a certain threshold. The effect of dispersal is to eliminate all positive effects, but I did not expect malnutrition to be a positive effect. I tried the new patch you released, Dispel will still clear malnutrition because malnutrition is still not counted as a negative effect?

WesCook commented 1 year ago

Malnourished does not receive a .setBeneficial() call, so it should not be considered a positive effect. I can't tell you why that particular cross-mod interaction isn't working as expected, but applying a potion effect that clears other potions does seem a little error-prone.

19300000 commented 1 year ago

Malnourished does not receive a call, so it should not be considered a positive effect. I can't tell you why that particular cross-mod interaction isn't working as expected, but applying a potion effect that clears other potions does seem a little error-prone..setBeneficial()

Ok, I see. Thank you for your answer. I will try other ways to solve the problem