Fix NullPointerException when attempting to allow for arbitrary input and output items

WesJD / AnvilGUI

Capture user input in Minecraft through an anvil GUI in under 20 lines of code

MIT License

466 stars 111 forks source link

Fix NullPointerException when attempting to allow for arbitrary input and output items #319

Closed Fabelz closed 3 months ago

Fabelz commented 4 months ago

As seen here on older versions of minecraft, the AnvilGUI will throw an error due to this patch not accounting for itemstacks not existing on specific server versions that require it. This patch simply just goes through all the versions that it may effect (this was only tested on 1_8_R3) and seeks to rectify it.

Once this patch is made, the problem is resolved and I can open the AnvilGUIs on 1.8 again, the library's version was bumped to accommodate this.

WesJD commented 3 months ago

Thanks for your help here.

Based on your description, is this PR ready, or are you still working on it?

Fabelz commented 3 months ago

@WesJD Not a problem, glad to help. This is fully ready to be merged in, to my knowledge.