WesJD / AnvilGUI

Capture user input in Minecraft through an anvil GUI in under 20 lines of code
MIT License
466 stars 111 forks source link

Move to gradle. #325

Open portlek opened 2 months ago

portlek commented 2 months ago

This will make our life easier when implementing #302 maven is relatively hard to add kotlin support, so it would be much more easier to make it in a Gradle environment.

0dinD commented 2 months ago

I don't see how this is related to #302 (which just seems to be a documentation issue), but maybe I have misunderstood what #302 is about?

maven is relatively hard to add kotlin support,

Kotlin support for what? You can already use Gradle with Kotlin to depend on AnvilGUI.


Whether AnvilGUI uses Maven or Gradle doesn't matter at all for the users of the library. In the end Maven and Gradle are compatible with each other when it comes to consuming dependencies.

So the decision to use Gradle for AnvilGUI seems to mostly be a matter of personal taste unless there is some specific Gradle feature that we want to use. I personally don't oppose moving to Gradle, so I trust whatever decision is made by the maintainers.

portlek commented 2 months ago

Kotlin support for what? You can already use Gradle with Kotlin to depend on AnvilGUI.

im not talking about that. i was talking about the #302 to make it easier to implement.

0dinD commented 2 months ago

Yeah I had just misunderstood what #302 was about, your argument makes sense now. It seems doable to build Kotlin code with Maven, but I would also not be surprised if Jetbrains has given the Gradle plugins for Kotlin more love than the Maven counterparts, so I trust your experience if you say that it's much easier in Gradle (I have not used Kotlin much, so I wouldn't know).