Fix NoSuchMethodError on latest Spigot builds for Minecraft 1.21

WesJD / AnvilGUI

Capture user input in Minecraft through an anvil GUI in under 20 lines of code

MIT License

481 stars 114 forks source link

Fix NoSuchMethodError on latest Spigot builds for Minecraft 1.21 #343

Closed 0dinD closed 2 months ago

0dinD commented 2 months ago

Fixes #342

0dinD commented 2 months ago

@mastercake10 @PikaMug @spnda Do any of you have time to help verify/test this? I'm sure Wes would appreciate it.

I've submitted a bunch of little PRs lately but this one is the most urgent in my opinion as AnvilGUI is entirely broken on the latest 1.21 builds. It would be nice to get it fixed before (or at least, not too long after) the CraftBukkit commit that caused the breakage makes its way into Paper.

WesJD commented 2 months ago

@0dinD if you've verified this to work, I'm good to merge it to fix the breaking change.

0dinD commented 2 months ago

@WesJD Yeah I tried different combinations of stuff and found that:

Previous AnvilGUI version (compiled against Spigot before the ABI-breaking commit) works before that commit, but not after
Re-compiling AnvilGUI against the latest Spigot NMS JAR (after the ABI-breaking commit) works after that commit, but not before
The version in this PR (which avoids the method whose ABI compatibility broke) works both before and after that commit

Granted, I didn't bother building an old version of Spigot, I just used the latest version of Paper (build 126, as of writing), which should be equivalent in terms of the ABI-breaking commit (because Paper still hasn't pulled the latest Spigot patches yet).

spnda commented 2 months ago

@spnda Do any of you have time to help verify/test this?

I linked an issue of one of my users having the same problem. However, my PC broke a few days ago so I don't have anything setup for Java/Minecraft development right now, so I will have to pass right now, sorry. I might try to setup stuff tomorrow, if I find the time.

mastercake10 commented 2 months ago

looking good

WesJD commented 2 months ago

Awesome, just increment the patch version and good to merge. Make sure the version isn't the same as in #346 ;)

0dinD commented 2 months ago

Done! I'll wait with incrementing the version for #346 until this PR is merged, because either way they'll just be in conflict with each other and I'll have to rebase after you merge. This also leaves you the option of releasing both fixes with a single version-bump if you merge both PRs in their current forms.