search

Wesley1808 / ServerCore

A mod that aims to optimize the minecraft server.
75 stars 11 forks source link

Player login causes the server to crash #108

Open Anthem4867 opened 1 month ago

Anthem4867 commented 1 month ago

Hello Wesley1808,

I encountered an issue while using ServerCore. When players with poor network connections log into the server, it causes the server to crash. I suspect this might be due to optimizations related to player login in the mod. Since my server has many mods and the server logs are incomplete, it's difficult to pinpoint the exact cause. Therefore, I would like to request an option in the configuration file to disable this specific optimization.

Thank you.

Anthem4867 commented 1 month ago

Mod version: ServerCore-fabric-1.5.1+1.20.1 Server version: fabric-server-mc.1.20.1-loader.0.15.11-launcher.1.0.1 FabricAPI version: fabric-api-0.92.2+1.20.1

Anthem4867 commented 1 month ago

2024-07-13-7.log.gz

2024-07-13-6.log.gz

Wesley1808 commented 1 month ago

Never seen this happen with plenty of poor connections before, so its probably a mod incompatibility. Do you have any crash reports of when this happened? You can find them in <server_directory>/crash-reports.

The logs don't really tell me all that much about what actually caused it. The optimization in question also pretty small and seems really unlikely to cause crashes, so providing a way to disable would most likely not even fix it.

Anthem4867 commented 1 month ago

I checked the /crash-reports but did not find any crash reports there.

Wesley1808 commented 1 month ago

You could try to disable these specific optimizations to see if that fixes it (though I doubt it) through the mixinconfig file in the servercore jar.

  1. Close the server and open the jar as archive (as if its a zip file, tools like 7zip work for this)
  2. Open servercore.common.mixins.json
  3. Delete the lines "optimizations.players.PlayerListMixin", and "optimizations.players.ServerPlayerMixin",
  4. Save the file and close it (make sure it actually saves), and start the server back up again.

I assume you've also made sure this doesn't still happen without servercore installed?