search

Wesley1808 / ServerCore

A mod that aims to optimize the minecraft server.
77 stars 11 forks source link

Incompatibility between Cyclonite and ServerCore on 1.18.2 #36

Closed youmukonpaku1337 closed 2 years ago

youmukonpaku1337 commented 2 years ago

Describe the bug Servercore and Cyclonite (https://github.com/KenRouKoro/C3H6N6O6/) are incompatible because of ServerCore's mixin check, as told by KenRouKoro here: https://github.com/KenRouKoro/C3H6N6O6/issues/6#issuecomment-1177334006

Reproduce Install the Fabric Loader on a server Install the Fabric API from here: https://modrinth.com/mod/fabric-api Install ServerCore from here: https://modrinth.com/mod/servercore Install Cyclonite beta 1 from here: https://modrinth.com/mod/c3h6n6o6

Expected behavior Server launches and works fine

Versions -Latest is not a version! ServerCore: 1.2.9 Minecraft: 1.18.2 Cyclonite: Beta 1 from GH Actions or Modrinth Fabric Loader: 0.14.8 on 1.18.2 Fabric API: 0.57.0+1.18.2

Mod incompatibilities ServerCore is the issue here it seems.

Extra info example log: https://pastebin.com/embed_js/VY1xryjr (issues begin at line 156) This should probably happen on 1.19 too considering that Cyclonite can launch on 1.19 with a dependency override

youmukonpaku1337 commented 2 years ago

can be resolved with a toggle for the mixin check in servercore's config

youmukonpaku1337 commented 2 years ago

also note that Cyclonite isn't MCMTFabric's entity ticking code separated from MCMTFabric, it's a full rewrite except for the data repair sections, so cyclonite has a lot of potential for performance, especially with C2ME

Wesley1808 commented 2 years ago

I don't really maintain 1.18.2 anymore - too much effort to keep maintaining mods for multiple major versions of the game.

I tried to get Cyclonite to work in 1.19, but that definitely didn't work out very well. It just spams error logs about the legacy random source being accessed off-thread (which is expected as its a new change in 1.19).

I can make a quick update for 1.18.2 (download here) that just disables activation range when its installed, but I doubt I'll make a new CF / Modrinth release for it. I can make the same changes for 1.19, but I can't really test if theres any other compatibility issues there as long as it hasn't updated properly.

As a sidenote for the author of cyclonite - I might've missed it but is there any reason as to why it tries to run non-passenger entity ticks async, but it doesn't do the same for passenger entity ticks? Just curious.

Edit: It also might be useful to mention somewhere that it requires some library to actually boot up, that saves others some time aswell. Rather than telling them where to download their own mod ;)

youmukonpaku1337 commented 2 years ago

yeah i know, kenroukoro will mention that it requires a lib in next release, also no worries, thanks for the build