search

Wesley1808 / ServerCore

A mod that aims to optimize the minecraft server.
77 stars 11 forks source link

Crash with Suggestion Tweaker #59

Closed SplendidAlakey closed 1 year ago

SplendidAlakey commented 1 year ago

Describe the bug

After updating ServerCore to 1.3.5, the game crashes on startup, if Suggestion Tweaker is also installed.

Rolling back to 1.3.3 lets the game start, hence reporting here.

Reproduce

  1. Install ServerCore 1.3.5 and Suggestion Tweaker
  2. Run the game

Expected behavior

No crash.

Versions -Latest is not a version!

ServerCore: 1.3.5 Minecraft: 1.19.2

Mod incompatibilities

Suggestion Tweaker

Logs: https://gist.github.com/SplendidAlakey/c088c34100a65ccfbe609f794c3400b5

Wesley1808 commented 1 year ago

Hey, thanks for reporting this issue. It seems to happen because of the new multi-platform setup, and some platform specific methods need to be loaded before mixin loads to load the config and check for other mods being loaded.

There are a few platform-specific methods using minecraft classes in there aswell though, and even if they aren't actually used until later the classloader will load them immediately with the rest, causing any mods mixing into them to crash. Will probably have to look into splitting up the platform specific methods to fix this.

Wesley1808 commented 1 year ago

Would you be able to try out the development build listed here to see if the issue still persists? In my testing it works properly, at least in dev environment. If it works I'll be pushing this to all the other branches aswell.

SplendidAlakey commented 1 year ago

Yep, that works, thank you!