search

Wesley1808 / ServerCore

A mod that aims to optimize the minecraft server.
76 stars 11 forks source link

Servercore Breaks FTBEssentials `/rtp` command #69

Closed Aiidoneus closed 4 months ago

Aiidoneus commented 1 year ago

Describe the bug As soon as I install servercore on the server, it breaks FTB-Essentials /rtp command. It doesn't crash or anything like that but when trying to run the /rtp command, is immediatly returns saying "Could not find a valid location to teleport to."

Reproduce Steps to reproduce the behavior: Install servercore on a server with FTB-Essentials

Expected behavior RTP command to teleport properly

Versions -Latest is not a version! ServerCore: 1.3.5 Minecraft: 1.19.2

Wesley1808 commented 1 year ago

Does this still happen when you set optimizations.reduce_sync_loads to false? And is this on Forge or Fabric?

Wesley1808 commented 1 year ago

Oh wait, this is probably a duplicate of #62 with different configuration which was fixed with commit https://github.com/Wesley1808/ServerCore/commit/03c993e9b3823d63b39e999c7d9cb5c4f946b01f I will probably backport 1.3.7 to 1.19.2 soon since its still used in a lot of modpacks.

Aiidoneus commented 1 year ago

Oh sorry.i didn't realize that was the same issue? We don't crash at all, but just error out. So I wasn't sure it was related

Wesley1808 commented 1 year ago

The results are indeed a bit different, but there's a very high chance its caused by the same patch. I haven't noticed anything else that could cause that and it was more of a freeze / lag issue then an actual crash (crash caused by watchdog for taking too long), which can be affected by the configuration of the RTP.

I might be wrong about this since I haven't actually had the time yet to properly test this (apologies if I'm wrong), but if you want to give it a try you can remove the line "optimizations.tickets.ServerLevelMixin", in servercore.common.mixins.json inside the .jar file.

Aiidoneus commented 1 year ago

Yeah. I just tried removing that and it did indeed fix the issue!

katubug commented 4 months ago

Oh wait, this is probably a duplicate of #62 with different configuration which was fixed with commit 03c993e I will probably backport 1.3.7 to 1.19.2 soon since its still used in a lot of modpacks.

Hi, we're experiencing a freezing issue with rtp on our server for the Cottage Witch modpack on 1.19.2, did this fix get backported? Thanks for your time!

Wesley1808 commented 4 months ago

Apologies, must have forgotten to backport it. Probably won't make a release for it, but you'll be able to download it from github actions here.

katubug commented 4 months ago

I'm guessing doing that won't allow me to export the mod with my Curseforge modpack? Thank you btw!

On Mon, May 27, 2024, 5:55 PM Wesley1808 @.***> wrote:

Closed #69 https://github.com/Wesley1808/ServerCore/issues/69 as completed.

— Reply to this email directly, view it on GitHub https://github.com/Wesley1808/ServerCore/issues/69#event-12950034397, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7XE5X4ETRTV2GEE5SAJXTZEO2X7AVCNFSM6AAAAAA3FNWCR2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHE2TAMBTGQZTSNY . You are receiving this because you commented.Message ID: @.***>

Wesley1808 commented 4 months ago

You should be able to run it by simply adding it to your server - adding external files only on the server shouldn't be much of a problem as far as I know. Exporting the mod with a curseforge modpack probably won't work, as I would assume that requires the file to be uploaded there.

katubug commented 4 months ago

Gotcha, that sounds right. Thank you!

On Mon, May 27, 2024, 6:04 PM Wesley1808 @.***> wrote:

You should be able to run it by simply adding it to your server - adding external files only on the server shouldn't be much of a problem as far as I know. Exporting the mod with a curseforge modpack probably won't work, as I would assume that requires the file to be uploaded there.

— Reply to this email directly, view it on GitHub https://github.com/Wesley1808/ServerCore/issues/69#issuecomment-2134125413, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7XE5WKZIFSB3SA3GGFN7DZEO3XPAVCNFSM6AAAAAA3FNWCR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZUGEZDKNBRGM . You are receiving this because you commented.Message ID: @.***>

katubug commented 2 months ago

You should be able to run it by simply adding it to your server - adding external files only on the server shouldn't be much of a problem as far as I know. Exporting the mod with a curseforge modpack probably won't work, as I would assume that requires the file to be uploaded there.

Hi, sorry to necro this thread - would you consider making this an official curseforge release for the 1.19.2 version? I want to recommend people install servercore, but the github actions file is no longer available, and it would be a lot easier for the end user if it was on curseforge. I appreciate you taking the time to read this, regardless.