Wesley1808 / ServerCore

A mod that aims to optimize the minecraft server.
75 stars 11 forks source link

Incompatibility: ServerCore & DynamicFPS causes chunkloading to hang on world generation. #77

Closed PlayfulPiano closed 11 months ago

PlayfulPiano commented 11 months ago

Describe the bug When using ServerCore and DynamicFPS together, building the world generation gets stuck on "generating server chunks" without ever building client chunks. This gets the former's chunk total past twice the goal commonly (~400) and the world never generates.

Reproduce Steps to reproduce the behavior:

Expected behavior A clear description of what you expected to happen.

Versions -Latest is not a version! ServerCore: servercore-1.2.9-1.18.2 DynamicFPS: dynamic-fps-3.2.1+minecraft-1.16.5-to-1.18.2 Minecraft: 1.18.2

Mod incompatibilities Dynamic FPS (https://www.curseforge.com/minecraft/mc-mods/dynamic-fps)

Config File Contents:

dynamic_fps.json dynamic_fps.txt

dynamicfps.toml dynamicfps.txt

servercore.toml servercore.txt

Log: latest.log

Image: image

Wesley1808 commented 11 months ago

Can you try to reproduce this with version 1.3.5+1.18.2? 1.2.9 is quite old at this point.

PlayfulPiano commented 11 months ago

sometimes I wish there were autoupdaters

let me go check quickly

Edit: oh wait no I see now, I was checking only modrinth for server core and it didn't have 1.3.5 there.

PlayfulPiano commented 11 months ago

Nope, issue still happening with v1.3.5 of servercore and v.3.2.1 of dynamicfps.

Wesley1808 commented 11 months ago

I'll try to see if I can reproduce this. Is this done on a client loading a singleplayer world?

PlayfulPiano commented 11 months ago

loading or generating a single player world yes. I'm using quilt instead of fabric in case you can't reproduce it on the latter.

Wesley1808 commented 11 months ago

This isn't a compat issue between ServerCore and Dynamic FPS, its between Fastload and Dynamic FPS. ServerCore + Dynamic FPS works fine, and I can reproduce this without servercore.

Relevant issue: https://github.com/BumbleSoftware/Fastload/issues/108

PlayfulPiano commented 11 months ago

huh, interesting. Didn't realize that was the issue. Although from what I remember when trying to figure out the conflict, I swear I remember using both together before without the problem occurring, with it only getting introduced when I added server core, but i'll check rn.

PlayfulPiano commented 11 months ago

Yep, that fixed it! thanks for letting me know what the cause was.

PlayfulPiano commented 11 months ago

well then uh it's now causing a crash in game but it's probably related to a different mod now? idk but i'll post it within fastload's comment.