search

Wesley1808 / ServerCore

A mod that aims to optimize the minecraft server.
75 stars 11 forks source link

Mixin conflict with MapAtlas #80

Closed PlayfulPiano closed 10 months ago

PlayfulPiano commented 10 months ago

Describe the bug Within my latest.log when loading both ServerCore and MapAtlas, I get the following mixins conflict. I haven't noticed any actual functionality issues.

Reproduce Steps to reproduce the behavior: Launch both mods together, and you'll see this conflict within your latest.lgos

Expected behavior No instance of a mixin conflict I would assume (I'm new to mixins)

Versions -Latest is not a version! ServerCore: Fabric 1.3.5 Minecraft: 1.18.2

Mod incompatibilities List any installed mods you think might play a role in causing this bug. MapAtlas 2.3.0

Log message:

[03:35:54] [main/WARN]: @Redirect conflict. Skipping servercore.common.mixins.json:optimizations.misc.MapItemSavedDataMixin from mod servercore->@Redirect::servercore$reduceInventoryIteration(Lnet/minecraft/class_1661;Lnet/minecraft/class_1799;)Z with priority 900, already redirected by mapatlases.mixins.json:MapStateTrinketsMixin from mod map_atlases->@Redirect::containsProxy(Lnet/minecraft/class_1661;Lnet/minecraft/class_1799;)Z with priority 1100

Wesley1808 commented 10 months ago

That is intended mixin behavior. That redirect is a standalone map optimization, it isn't required for anything else and should get skipped (hence the error) if another mod redirects the same method call.

The opt won't apply but the other mod will work as intended.

PlayfulPiano commented 10 months ago

Ah thank you, not familiar with mixin things so I wanted to report.