search

Wesley1808 / ServerCore

A mod that aims to optimize the minecraft server.
75 stars 11 forks source link

Incompatibility with "IncreaseMobCaps"? #87

Open Apotrox opened 10 months ago

Apotrox commented 10 months ago

Describe the bug As the title states, i think there is an incompatibility with the Mod IncreaseMobCaps/MobCapBooster. The changes to the caps made from the mod do not appear to have any influence on the data shown by servercore. So increasing the Creature cap to lets say 50, servercore still reports it as 10. Which it still is.

Reproduce Installing MobCapBooster and ServerCore for 1.19.2.

Expected behavior A reported increase in one specific mob cap.

Versions -Latest is not a version! ServerCore: 1.3.5 Minecraft: 1.19.2

Mod incompatibilities MobCapBooster

Modlist Alex's Mobs BadPackets Balm Citadel CloudStorage Collective Corpse Cupboard WhenDungeonsArise Ferritecore MobCapBooster InventorySorter JEI konkrete moonlight Radium rightClickHarvest Servercore Smoothchunk sophisticatedCore Sophisitcated Backpacks Spark Starlight Supplementaries Terralith TreeHarvester Waystones WTHIT

Also, yes i do know i can increase the MobCap globally with Servercore. But it'd be nicer to be able to increase just one specific cap, as i really dont want to play with 350 monsters just because i still have my cow farm loaded ;) So, also a Feature Request, please give the player the possibility to modify the specific caps for the MobCategories?

Kirisoup commented 8 months ago

afaik, minecraft caps monsters and animals in different ways. You don't need your animal cap to be 70 to have 70 animals, they simply spawn when you discover new chunks, and can easily surpass the cap.

Not so sure on the two water categories tho.

Sorry if this didn't really help that much on the problem, just want you to know that modifying mobcap by category might not be as useful as you think.

Wesley1808 commented 8 months ago

I'm pretty sure this incompatibility was fixed with commit https://github.com/Wesley1808/ServerCore/commit/2c521cdcc36f5d652f61345da839889457090061 (not on 1.19.2 though).

I didn't bother with making a different cap for each category as there are already other mods that do that, and servercore's multiplier should (in theory) be able to work fine on top of that.