search

Wesley1808 / ServerCore

A mod that aims to optimize the minecraft server.
77 stars 11 forks source link

[Bug/Compatibility]Servercore 1.3.9 with c2me caused the server to randomly crashes #93

Open UnnamedWei opened 9 months ago

UnnamedWei commented 9 months ago

Describe the bug A clear description of what the bug is. The newest version of servercore seems have a confilct with the chunk optimization mod c2me, shows in the crash report

Reproduce Steps to reproduce the behavior:

  1. Start the server
  2. The server running for a day or couple of hours
  3. Randomly crashes

Expected behavior A clear description of what you expected to happen. Fix the compatibility with c2me

Versions -Latest is not a version! ServerCore: 1.3.9 Minecraft: 1.20.1 Fabric

Mod incompatibilities List any installed mods you think might play a role in causing this bug. c2me

Wesley1808 commented 9 months ago

Can you provide the crash report? I've been using servercore and c2me together for years now without problems, the chance that I'd be able to reproduce this is astronomically low.

UnnamedWei commented 9 months ago

I replaced it with 1.3.7 but still happening, the last crash report has the mixintrace installed. crash-2024-02-05_14.17.13-server.txt crash-2024-02-05_14.42.47-server.txt crash-2024-02-05_14.44.17-server.txt crash-2024-02-05_14.55.14-server.txt crash-2024-02-06_11.42.36-server.txt

Wesley1808 commented 9 months ago

Seems like the issue here in all of these is caused by certain data structures being modified on non-server threads, which I'm pretty sure doesn't ever happen in vanilla. Then the server thread tries to use that data structure thats currently being modified and runs into an error. It makes the error stacktrace difficult to read since its very likely that none of it is actually relevant to the cause of the issue, as it occurred on another thread.

ServerCore doesn't touch it in any way either, the 1 crash report it showed up in only shows it crashing further down the line on a method call that the vanilla game would do in the exact same location regardless of whether servercore is installed. It doesn't mess with threading either.

Do you have any other mods you know that might try to run some vanilla logic offthread? C2ME would come to mind, but I wouldn't really expect it given I've ran it without issues like this for at least 1-2 years.

UnnamedWei commented 9 months ago

Roger that, can I provide our mod list to you? This problem is really bothering our server and we will be very grateful, thanks a lot

Wesley1808 commented 9 months ago

The mod list is already in the crash report but nothing really directly stood out to me, so I'm afraid I can't help much in that regard. I don't really have the time or motivation to search the whole list trying to find the exact mod and potentially specific mod functionality thats causing the issue.