Wesleyan-Media-Project / creative_overview

An overview of all repos belonging to the CREATIVE project
Other
1 stars 0 forks source link

Look into file path/name inconsistencies #15

Closed bella-tassone closed 5 months ago

bella-tassone commented 10 months ago

I have marked all possible inconsistencies in the Google Drive Mentions sheet in red. This includes places where outdated files may be used, as well as outdated paths. I'm a little reluctant to make the changes in the repositories myself without confirmation, so if someone could take a second look I'd really appreciate it!

The sheet has all the information, but repositories that may have concerns specifically include:

Reach out to me if there are any questions or concerns, and thank you for the help!

atlasharry commented 10 months ago

Hi Bella, for " ad_tone, uses a different path for file FECIDs_onTV_thru110320.dta." I think the path mentioned in the sheet "Data/2020/tv_2020/FECIDs_onTV_thru110320.dta" indicates the its path in the Google Drive. But indeed, this path is different in the code: sponsor_to_fecid <- read_dta("../data/tv_sponsor_to_fecid/FECIDs_onTV_thru110320.dta")

a-jacewicz commented 10 months ago

Hi Bella, I believe I've fixed the issues in the ad-level-party-classifiers repo as part of what I was doing this week! Let me know if I'm missing something/that doesn't seem correct to you.

SebastianZimmeck commented 10 months ago

Currently, the file paths for fb_2020 may need fixing, but this is currently not a priority because the fb_2020 repo is not part of what was promised to the NSF.

entity_linking is another 2020 repo that will not be published. So, not a priority either.

party_classifier is fixed.

attack_like will be addressed by @furkmak and @Meiqingx. Related to the issue we discussed in meeting January 18, 2024.

ad_tone is clarified.

SebastianZimmeck commented 10 months ago

There is nothing new here. @atlasharry and @a-jacewicz are taking care of this.

SebastianZimmeck commented 5 months ago

@atlasharry and @a-jacewicz is there anything left to do here? If not, can you close this issue?

atlasharry commented 5 months ago

I think we are all good for this issue!