Incomplete dark mode support

avi12 commented 1 year ago

Describe the bug

To reproduce

Steps to reproduce the behavior:

Start from light mode
Turn on dark mode on the OS

Expected behavior

Desktop (please complete the following information):

OS: Win`0 Pro 22H2
Browser: Brave
Browser version: 1.46.144
Extension version: 2.36.33

Other extensions:

Does the bug still persist when you disable all other extensions? If not, which other extension conflicts with the Ambient light for the YouTube extension? Haven't tried

Additional context

Keep in mind that YouTube's dark mode doesn't auto-change. It only applies on page load

WesselKroos commented 1 year ago

This is a known limitation because the extension reads the current theme on pageload and then remembers that theme as the default. It cannot update the default theme when the theme is changed by the user via one of the following methods:

via the YouTube settings the top right menu
via the OS settings

This is a technical limitation because there seems to be no way for the extension to know if a "theme changed" event is triggered by the extension itself, from the YouTube settings or from the OS settings. It is also not possible to know if the theme in the YouTube settings is set to "Device theme" or a specific theme. In which case it should ignore the theme in the OS setting, further complicating this decision of what theme is the default theme.

@avi12 Feel free to send in idea's on how this can be achieved. For now I'll mark this issue as Abandoned.

avi12 commented 1 year ago

Since by default YouTube's theme doesn't dynamically change, your extension's colors shouldn't change either

WesselKroos commented 1 year ago

On my pc in the Brave browser YouTube's theme does not change when the system changes from light theme to dark theme. The theme also does not change when Ambient light is enabled.

avi12 commented 1 year ago

Very interesting In my case, YouTube's theme doesn't change but Ambilight's theme does

WesselKroos commented 1 year ago

Strange. Here's a screenrecording:

https://user-images.githubusercontent.com/31220528/210886729-3db61a77-1148-4f25-9096-17e18fba7c46.mp4

avi12 commented 1 year ago

https://user-images.githubusercontent.com/6422804/210895496-48277db8-8a30-4b11-87e7-a617c610b9a9.mp4

WesselKroos commented 1 year ago

It's probably because I updated the styling of some new YouTube design elements in the latest releases. Glad to hear that it has been resolved!

avi12 commented 1 year ago

The weird is that it hasn't actually been resolved In one video, the styling did not change, whereas in another, they did, so I don't know what's up with that

WesselKroos commented 1 year ago

~~Oh, then I might have switched some styling. And that could also indicate that I have some influence on what happens.~~

~~Do you have some examples of how things changed? Maybe we can find the logic in it.~~

WesselKroos commented 1 year ago

~~Btw, does it also happen when you logged out of your account? (In incognito mode for example?)~~

~~Because someone else has reported another bug that he only has when he's logged in. It could be that YouTube is testing out a feature on a select group of accounts.~~

WesselKroos commented 1 year ago

In light of #159 I was able to dynamically change the YouTube theme when I change my Windows theme. The reason why I was unable to reproduce this was because YouTube seems to test new/old features on a small group of YouTube accounts, which I do not belong to.

WesselKroos commented 1 year ago

I was able to reproduce this only one time, so I might have enabled an experimental YouTube feature flag accidentally at that time. Sadly I did not save which one it was.

@avi12 Can you share the experimental flags that are enabled on your account when YouTube switches directly based on the Windows theme?

You can get the experimental flags by executing this javascript line in the DevTools console:

ytcfg.get('EXPERIMENT_FLAGS')

Then: right click > Copy object

avi12 commented 1 year ago

{
  "H5_enable_full_pacf_logging": true,
  "H5_use_async_logging": true,
  "allow_skip_networkless": true,
  "autoescape_tempdata_url": true,
  "background_thread_flush_logs_due_to_batch_limit": true,
  "browse_next_continuations_migration_playlist": true,
  "c3_watch_page_component": true,
  "cache_utc_offset_minutes_in_pref_cookie": true,
  "cancel_pending_navs": true,
  "check_user_lact_at_prompt_shown_time_on_web": true,
  "clear_user_partitioned_ls": true,
  "client_respect_autoplay_switch_button_renderer": true,
  "cold_missing_history": true,
  "csi_on_gel": true,
  "decorate_autoplay_renderer": true,
  "defer_menus": true,
  "defer_overlays": true,
  "defer_rendering_outside_visible_area": true,
  "deprecate_csi_has_info": true,
  "deprecate_pair_servlet_enabled": true,
  "deprecate_two_way_binding_child": true,
  "deprecate_two_way_binding_parent": true,
  "desktop_add_to_playlist_renderer_dialog_popup": true,
  "desktop_adjust_touch_target": true,
  "desktop_animate_miniplayer": true,
  "desktop_client_release": true,
  "desktop_delay_player_resizing": true,
  "desktop_enable_dmpanel_click_drag_scroll": true,
  "desktop_enable_dmpanel_scroll": true,
  "desktop_enable_dmpanel_wheel_scroll": true,
  "desktop_image_cta_no_background": true,
  "desktop_keyboard_capture_keydown_killswitch": true,
  "desktop_log_img_click_location": true,
  "desktop_mix_use_sampled_color_for_bottom_bar": true,
  "desktop_mix_use_sampled_color_for_bottom_bar_search": true,
  "desktop_mix_use_sampled_color_for_bottom_bar_watch_next": true,
  "desktop_notification_high_priority_ignore_push": true,
  "desktop_notification_set_title_bar": true,
  "desktop_persistent_menu": true,
  "desktop_sparkles_light_cta_button": true,
  "desktop_swipeable_guide": true,
  "desktop_themeable_vulcan": true,
  "desktop_touch_gestures_usage_log": true,
  "desktop_use_new_history_manager": true,
  "disable_child_node_auto_formatted_strings": true,
  "disable_dependency_injection": true,
  "disable_exif_rotation_for_image_posts": true,
  "disable_features_for_supex": true,
  "disable_legacy_desktop_remote_queue": true,
  "disable_open_in_new_window_on_discovery_ads_search_desktop": true,
  "disable_pacf_logging_for_memory_limited_tv": true,
  "disable_rich_grid_inline_player_pop_out": true,
  "disable_simple_mixed_direction_formatted_strings": true,
  "disable_thumbnail_preloading": true,
  "embeds_web_enable_replace_unload_w_pagehide": true,
  "embeds_web_nwl_disable_nocookie": true,
  "enable_audio_pivot_back_nav_button": true,
  "enable_button_behavior_reuse": true,
  "enable_call_to_action_clarification_renderer_bottom_section_conditions": true,
  "enable_client_sli_logging": true,
  "enable_client_streamz_web": true,
  "enable_commerce_action_request_sequencing": true,
  "enable_desktop_amsterdam_info_panels": true,
  "enable_docked_chat_messages": true,
  "enable_gel_log_commands": true,
  "enable_get_account_switcher_endpoint_on_webfe": true,
  "enable_handles_account_menu_switcher": true,
  "enable_handles_in_mention_suggest_posts": true,
  "enable_handoff_location_2fa_on_mweb": true,
  "enable_header_channel_handler_ui": true,
  "enable_hlp_client_icon_pick": true,
  "enable_image_poll_post_creation": true,
  "enable_inline_preview_controls": true,
  "enable_inline_shorts_on_wn": true,
  "enable_madison_search_migration": true,
  "enable_masthead_quartile_ping_fix": true,
  "enable_memberships_and_purchases": true,
  "enable_mentions_in_reposts": true,
  "enable_microformat_data": true,
  "enable_mixed_direction_formatted_strings": true,
  "enable_multi_image_post_creation": true,
  "enable_names_handles_account_switcher": true,
  "enable_offer_suppression": true,
  "enable_on_yt_command_executor_command_to_navigate": true,
  "enable_poll_choice_border_on_web": true,
  "enable_polymer_resin": true,
  "enable_polymer_resin_migration": true,
  "enable_post_cct_links": true,
  "enable_post_scheduling": true,
  "enable_premium_voluntary_pause": true,
  "enable_programmed_playlist_color_sample": true,
  "enable_programmed_playlist_redesign": true,
  "enable_purchase_activity_in_paid_memberships": true,
  "enable_reel_watch_sequence": true,
  "enable_rendererstamper_listener_cleanup": true,
  "enable_rta_manager": true,
  "enable_seedless_shorts_url": true,
  "enable_server_stitched_dai": true,
  "enable_service_ajax_csn": true,
  "enable_servlet_errors_streamz": true,
  "enable_servlet_streamz": true,
  "enable_sfv_audio_pivot_url": true,
  "enable_shorts_on_library": true,
  "enable_shorts_singleton_channel_web": true,
  "enable_signals": true,
  "enable_skip_ad_guidance_prompt": true,
  "enable_skippable_ads_for_unplugged_ad_pod": true,
  "enable_smearing_expansion_dai": true,
  "enable_squiffle_gif_handles_landing_page": true,
  "enable_streamline_repost_flow": true,
  "enable_structured_description_shorts_web_mweb": true,
  "enable_tectonic_ad_ux_for_halftime": true,
  "enable_third_party_info": true,
  "enable_topsoil_wta_for_halftime_live_infra": true,
  "enable_unavailable_videos_watch_page": true,
  "enable_unified_show_page_web_client": true,
  "enable_watch_next_pause_autoplay_lact": true,
  "enable_web_ketchup_hero_animation": true,
  "enable_web_poster_hover_animation": true,
  "enable_web_scheduler_signals": true,
  "enable_web_shorts_audio_pivot": true,
  "enable_yoodle": true,
  "enable_ypc_spinners": true,
  "enable_ytc_refunds_submit_form_signal_action": true,
  "endpoint_handler_logging_cleanup_killswitch": true,
  "export_networkless_options": true,
  "external_fullscreen": true,
  "external_fullscreen_with_edu": true,
  "fill_single_video_with_notify_to_lasr": true,
  "gcf_config_store_enabled": true,
  "gda_enable_playlist_download": true,
  "gfeedback_for_signed_out_users_enabled": true,
  "global_spacebar_pause": true,
  "gpa_sparkles_ten_percent_layer": true,
  "h5_companion_enable_adcpn_macro_substitution_for_click_pings": true,
  "h5_inplayer_enable_adcpn_macro_substitution_for_click_pings": true,
  "hide_endpoint_overflow_on_ytd_display_ad_renderer": true,
  "html5_enable_ads_client_monitoring_log_tv": true,
  "html5_enable_single_video_vod_ivar_on_pacf": true,
  "html5_log_trigger_events_with_debug_data": true,
  "html5_recognize_predict_start_cue_point": true,
  "html5_server_stitched_dai_group": true,
  "html5_web_enable_halftime_preroll": true,
  "il_use_view_model_logging_context": true,
  "include_autoplay_count_in_playlists": true,
  "is_browser_support_for_webcam_streaming": true,
  "is_part_of_any_user_engagement_experiment": true,
  "json_condensed_response": true,
  "kevlar_app_shortcuts": true,
  "kevlar_appbehavior_attach_startup_tasks": true,
  "kevlar_append_toggled_engagement_panels_top": true,
  "kevlar_appshell_service_worker": true,
  "kevlar_autofocus_menu_on_keyboard_nav": true,
  "kevlar_autonav_popup_filtering": true,
  "kevlar_av_eliminate_polling": true,
  "kevlar_background_color_update": true,
  "kevlar_cache_cold_load_response": true,
  "kevlar_cache_on_ttl_player": true,
  "kevlar_cache_on_ttl_search": true,
  "kevlar_calculate_grid_collapsible": true,
  "kevlar_cancel_scheduled_comment_jobs_on_navigate": true,
  "kevlar_center_search_results": true,
  "kevlar_channel_creation_form_resolver": true,
  "kevlar_channel_trailer_multi_attach": true,
  "kevlar_chapters_list_view_seek_by_chapter": true,
  "kevlar_clear_duplicate_pref_cookie": true,
  "kevlar_clear_non_displayable_url_params": true,
  "kevlar_client_side_screens": true,
  "kevlar_command_handler": true,
  "kevlar_command_handler_clicks": true,
  "kevlar_command_handler_formatted_string": true,
  "kevlar_command_url": true,
  "kevlar_decorate_endpoint_with_onesie_config": true,
  "kevlar_delay_watch_initial_data": true,
  "kevlar_disable_background_prefetch": true,
  "kevlar_disable_pending_command": true,
  "kevlar_downloads_on_home": true,
  "kevlar_dragdrop_fast_scroll": true,
  "kevlar_dropdown_fix": true,
  "kevlar_droppable_prefetchable_requests": true,
  "kevlar_early_popup_close": true,
  "kevlar_enable_download_upsell_type_a": true,
  "kevlar_enable_editable_playlists": true,
  "kevlar_enable_reorderable_playlists": true,
  "kevlar_enable_shorts_prefetch_in_sequence": true,
  "kevlar_enable_shorts_response_chunking": true,
  "kevlar_enable_up_arrow": true,
  "kevlar_enable_upsell_on_video_menu": true,
  "kevlar_enable_ybp_op_for_shoptube": true,
  "kevlar_exit_fullscreen_leaving_watch": true,
  "kevlar_fix_playlist_continuation": true,
  "kevlar_flexible_menu": true,
  "kevlar_fluid_touch_scroll": true,
  "kevlar_frontend_queue_recover": true,
  "kevlar_gel_error_routing": true,
  "kevlar_guide_refresh": true,
  "kevlar_help_use_locale": true,
  "kevlar_hide_playlist_playback_status": true,
  "kevlar_hide_pp_url_param": true,
  "kevlar_hide_time_continue_url_param": true,
  "kevlar_home_skeleton": true,
  "kevlar_home_skeleton_hide_later": true,
  "kevlar_js_fixes": true,
  "kevlar_keyboard_button_focus": true,
  "kevlar_larger_three_dot_tap": true,
  "kevlar_lazy_list_resume_for_autofill": true,
  "kevlar_live_report_menu_item": true,
  "kevlar_local_innertube_response": true,
  "kevlar_macro_markers_keyboard_shortcut": true,
  "kevlar_masthead_store": true,
  "kevlar_mealbar_above_player": true,
  "kevlar_miniplayer": true,
  "kevlar_miniplayer_expand_top": true,
  "kevlar_miniplayer_play_pause_on_scrim": true,
  "kevlar_miniplayer_queue_user_activation": true,
  "kevlar_mix_handle_first_endpoint_different": true,
  "kevlar_modern_sd": true,
  "kevlar_network_banner": true,
  "kevlar_next_cold_on_auth_change_detected": true,
  "kevlar_nitrate_driven_tooltips": true,
  "kevlar_no_autoscroll_on_playlist_hover": true,
  "kevlar_op_infra": true,
  "kevlar_op_warm_pages": true,
  "kevlar_pandown_polyfill": true,
  "kevlar_passive_event_listeners": true,
  "kevlar_playback_associated_queue": true,
  "kevlar_player_cached_load_config": true,
  "kevlar_player_check_ad_state_on_stop": true,
  "kevlar_player_load_player_no_op": true,
  "kevlar_player_new_bootstrap_adoption": true,
  "kevlar_player_playlist_use_local_index": true,
  "kevlar_player_watch_endpoint_navigation": true,
  "kevlar_playlist_drag_handles": true,
  "kevlar_playlist_responsive": true,
  "kevlar_playlist_use_x_close_button": true,
  "kevlar_prefetch": true,
  "kevlar_prevent_polymer_dynamic_font_load": true,
  "kevlar_queue_use_update_api": true,
  "kevlar_refresh_gesture": true,
  "kevlar_refresh_on_theme_change": true,
  "kevlar_rendererstamper_event_listener": true,
  "kevlar_replace_short_to_short_history_state": true,
  "kevlar_request_sequencing": true,
  "kevlar_resolve_command_for_confirm_dialog": true,
  "kevlar_resolve_playlist_endpoint_as_watch_endpoint": true,
  "kevlar_response_command_processor_page": true,
  "kevlar_scroll_chips_on_touch": true,
  "kevlar_scrollbar_rework": true,
  "kevlar_service_command_check": true,
  "kevlar_set_internal_player_size": true,
  "kevlar_shell_for_downloads_page": true,
  "kevlar_should_maintain_stable_list": true,
  "kevlar_smart_downloads": true,
  "kevlar_smart_downloads_setting": true,
  "kevlar_startup_lifecycle": true,
  "kevlar_structured_description_content_inline": true,
  "kevlar_system_icons": true,
  "kevlar_tabs_gesture": true,
  "kevlar_text_inline_expander_formatted_snippet": true,
  "kevlar_three_dot_ink": true,
  "kevlar_thumbnail_fluid": true,
  "kevlar_toast_manager": true,
  "kevlar_topbar_logo_fallback_home": true,
  "kevlar_touch_feedback": true,
  "kevlar_touch_feedback_lockups": true,
  "kevlar_touch_gesture_ves": true,
  "kevlar_transcript_engagement_panel": true,
  "kevlar_tuner_run_default_comments_delay": true,
  "kevlar_tuner_should_defer_detach": true,
  "kevlar_typography_spacing_update": true,
  "kevlar_typography_update": true,
  "kevlar_unavailable_video_error_ui_client": true,
  "kevlar_unified_errors_init": true,
  "kevlar_use_response_ttl_to_invalidate_cache": true,
  "kevlar_use_vimio_behavior": true,
  "kevlar_use_ytd_player": true,
  "kevlar_variable_youtube_sans": true,
  "kevlar_vimio_use_shared_monitor": true,
  "kevlar_voice_logging_fix": true,
  "kevlar_voice_search": true,
  "kevlar_watch_cinematics": true,
  "kevlar_watch_color_update": true,
  "kevlar_watch_comments_ep_disable_theater": true,
  "kevlar_watch_drag_handles": true,
  "kevlar_watch_flexy_autonav_manager": true,
  "kevlar_watch_flexy_use_controller": true,
  "kevlar_watch_focus_on_engagement_panels": true,
  "kevlar_watch_gesture_pandown": true,
  "kevlar_watch_hide_comments_teaser": true,
  "kevlar_watch_hide_comments_while_panel_open": true,
  "kevlar_watch_js_panel_height": true,
  "kevlar_watch_metadata_refresh": true,
  "kevlar_watch_metadata_refresh_attached_subscribe": true,
  "kevlar_watch_metadata_refresh_clickable_description": true,
  "kevlar_watch_metadata_refresh_compact_view_count": true,
  "kevlar_watch_metadata_refresh_description_info_dedicated_line": true,
  "kevlar_watch_metadata_refresh_description_inline_expander": true,
  "kevlar_watch_metadata_refresh_description_primary_color": true,
  "kevlar_watch_metadata_refresh_for_live_killswitch": true,
  "kevlar_watch_metadata_refresh_full_width_description": true,
  "kevlar_watch_metadata_refresh_left_aligned_video_actions": true,
  "kevlar_watch_metadata_refresh_lower_case_video_actions": true,
  "kevlar_watch_metadata_refresh_narrower_item_wrap": true,
  "kevlar_watch_metadata_refresh_relative_date": true,
  "kevlar_watch_metadata_refresh_top_aligned_actions": true,
  "kevlar_watch_modern_metapanel": true,
  "kevlar_watch_modern_panels": true,
  "kevlar_watch_panel_height_matches_player": true,
  "kevlar_woffle": true,
  "kevlar_woffle_fallback_image": true,
  "kevlar_ytb_live_badges": true,
  "killswitch_toggle_button_behavior_resolve_command": true,
  "live_chat_banner_expansion_fix": true,
  "live_chat_collapse_merch_banner": true,
  "live_chat_enable_qna_banner_overflow_menu_actions": true,
  "live_chat_enable_qna_channel": true,
  "live_chat_increased_min_height": true,
  "live_chat_over_playlist": true,
  "live_chat_use_new_emoji_picker": true,
  "log_errors_through_nwl_on_retry": true,
  "log_heartbeat_with_lifecycles": true,
  "log_vis_on_tab_change": true,
  "log_web_endpoint_to_layer": true,
  "mdx_enable_privacy_disclosure_ui": true,
  "mdx_load_cast_api_bootstrap_script": true,
  "migrate_events_to_ts": true,
  "music_on_main_handle_playlist_edit_video_added_result_data": true,
  "mweb_actions_command_handler": true,
  "mweb_command_handler": true,
  "mweb_disable_set_autonav_state_in_player": true,
  "mweb_enable_consistency_service": true,
  "mweb_enable_hlp": true,
  "mweb_logo_use_home_page_ve": true,
  "mweb_navigate_to_watch_with_op": true,
  "networkless_gel": true,
  "networkless_logging": true,
  "no_sub_count_on_sub_button": true,
  "nwl_send_fast_on_unload": true,
  "nwl_send_from_memory_when_online": true,
  "offline_error_handling": true,
  "pageid_as_header_web": true,
  "parse_query_data_from_url": true,
  "pause_ad_video_on_desktop_engagement_panel_click": true,
  "pdg_enable_flow_logging_for_super_chat": true,
  "pdg_enable_flow_logging_for_super_stickers": true,
  "player_allow_autonav_after_playlist": true,
  "player_bootstrap_method": true,
  "player_doubletap_to_seek": true,
  "player_enable_playback_playlist_change": true,
  "player_endscreen_ellipsis_fix": true,
  "polymer_bad_build_labels": true,
  "polymer_task_manager_proxied_promise": true,
  "polymer_verifiy_app_state": true,
  "polymer_video_renderer_defer_menu": true,
  "polymer_warm_thumbnail_preload": true,
  "polymer_ytdi_enable_global_injector": true,
  "problem_walkthrough_sd": true,
  "qoe_send_and_write": true,
  "record_app_crashed_web": true,
  "reload_without_polymer_innertube": true,
  "remove_web_comment_id_cache": true,
  "remove_yt_simple_endpoint_from_desktop_display_ad_title": true,
  "rich_grid_watch_meta_side": true,
  "rich_grid_watch_show_watch_next": true,
  "scheduler_use_raf_by_default": true,
  "search_ui_enable_pve_buy_button": true,
  "search_ui_official_cards_enable_paid_virtual_event_buy_button": true,
  "searchbox_reporting": true,
  "serve_pdp_at_canonical_url": true,
  "service_worker_enabled": true,
  "service_worker_push_enabled": true,
  "service_worker_push_home_page_prompt": true,
  "service_worker_push_watch_page_prompt": true,
  "service_worker_subscribe_with_vapid_key": true,
  "shorts_enable_snap_stop": true,
  "should_clear_video_data_on_player_cued_unstarted": true,
  "show_civ_reminder_on_web": true,
  "skip_invalid_ytcsi_ticks": true,
  "skip_ls_gel_retry": true,
  "skip_setting_info_in_csi_data_object": true,
  "sponsorships_gifting_enable_announcements": true,
  "sponsorships_gifting_enable_opt_in": true,
  "sponsorships_gifting_enable_purchase": true,
  "start_client_gcf": true,
  "start_client_gcf_for_player": true,
  "super_sticker_emoji_picker_category_button_icon_filled": true,
  "suppress_error_204_logging": true,
  "track_webfe_innertube_auth_mismatch": true,
  "transport_use_scheduler": true,
  "use_ads_engagement_panel_desktop_footer_cta": true,
  "use_better_post_dismissals": true,
  "use_border_and_grid_wrapping_on_desktop_panel_tiles": true,
  "use_new_in_memory_storage": true,
  "use_new_nwl_initialization": true,
  "use_new_nwl_saw": true,
  "use_new_nwl_stw": true,
  "use_new_nwl_wts": true,
  "use_on_click_for_desktop_companion": true,
  "use_player_abuse_bg_library": true,
  "use_profilepage_event_label_in_carousel_playbacks": true,
  "use_request_time_ms_header": true,
  "use_rta_manager_for_async": true,
  "use_session_based_sampling": true,
  "use_shared_nsm": true,
  "use_shared_nsm_and_keep_yt_online_updated": true,
  "use_source_element_if_present_for_actions": true,
  "use_ts_visibilitylogger": true,
  "use_watch_fragments2": true,
  "verify_ads_itag_early": true,
  "vss_final_ping_send_and_write": true,
  "vss_playback_use_send_and_write": true,
  "warm_load_nav_start_web": true,
  "warm_op_csn_cleanup": true,
  "web_always_load_chat_support": true,
  "web_amsterdam_playlists": true,
  "web_amsterdam_post_mvp_playlists": true,
  "web_animated_like": true,
  "web_animated_like_lazy_load": true,
  "web_api_url": true,
  "web_appshell_purge_trigger": true,
  "web_appshell_refresh_trigger": true,
  "web_autonav_allow_off_by_default": true,
  "web_button_rework": true,
  "web_darker_dark_theme": true,
  "web_darker_dark_theme_deprecate": true,
  "web_dedupe_ve_grafting": true,
  "web_defer_shorts_ui": true,
  "web_defer_shorts_ui_phase2": true,
  "web_deprecate_service_ajax_map_dependency": true,
  "web_enable_history_cache_map": true,
  "web_enable_video_preview_migration": true,
  "web_enable_voz_audio_feedback": true,
  "web_engagement_panel_show_description": true,
  "web_ep_chevron_tap_target_size": true,
  "web_filled_subscribed_button": true,
  "web_forward_command_on_pbj": true,
  "web_gel_timeout_cap": true,
  "web_guide_ui_refresh": true,
  "web_hide_autonav_headline": true,
  "web_hide_autonav_keyline": true,
  "web_inline_player_enabled": true,
  "web_kevlar_enable_adaptive_signals": true,
  "web_log_memory_total_kbytes": true,
  "web_log_player_watch_next_ticks": true,
  "web_log_reels_ticks": true,
  "web_modern_ads": true,
  "web_modern_buttons": true,
  "web_modern_buttons_bl_survey": true,
  "web_modern_chips": true,
  "web_modern_dialogs": true,
  "web_modern_playlists": true,
  "web_modern_subscribe": true,
  "web_modern_typography": true,
  "web_move_autoplay_video_under_chip": true,
  "web_moved_super_title_link": true,
  "web_one_platform_error_handling": true,
  "web_player_autonav_toggle_always_listen": true,
  "web_player_autonav_use_server_provided_state": true,
  "web_player_decouple_autonav": true,
  "web_player_enable_early_warning_snackbar": true,
  "web_player_enable_ipp": true,
  "web_player_enable_premium_hbr_in_h5_api": true,
  "web_player_enable_premium_hbr_playback_cap": true,
  "web_player_entities_middleware": true,
  "web_player_move_autonav_toggle": true,
  "web_player_mutable_event_label": true,
  "web_player_should_honor_include_asr_setting": true,
  "web_player_small_hbp_settings_menu": true,
  "web_player_touch_mode_improvements": true,
  "web_player_use_new_api_for_quality_pullback": true,
  "web_player_watch_next_response": true,
  "web_prefetch_preload_video": true,
  "web_prs_testing_mode_killswitch": true,
  "web_repeating_chapters": true,
  "web_replace_thumbnail_with_image": true,
  "web_rounded_containers": true,
  "web_rounded_thumbnails": true,
  "web_search_inline_playback_mouse_enter": true,
  "web_segmented_like_dislike_button": true,
  "web_sheets_ui_refresh": true,
  "web_shorts_early_player_load": true,
  "web_shorts_progress_bar": true,
  "web_shorts_shelf_on_search": true,
  "web_shorts_skip_loading_same_index": true,
  "web_snackbar_ui_refresh": true,
  "web_structured_description_show_more": true,
  "web_use_cache_for_image_fallback": true,
  "web_yt_config_context": true,
  "woffle_clean_up_after_entity_migration": true,
  "woffle_orchestration": true,
  "your_data_entrypoint": true,
  "yt_network_manager_component_to_lib_killswitch": true,
  "ytidb_clear_embedded_player": true,
  "ytidb_fetch_datasync_ids_for_data_cleanup": true,
  "H5_async_logging_delay_ms": 30000,
  "addto_ajax_log_warning_fraction": 0.1,
  "autoplay_pause_by_lact_sampling_fraction": 0,
  "browse_ajax_log_warning_fraction": 1,
  "cinematic_watch_effect_opacity": 0.4,
  "kevlar_tuner_clamp_device_pixel_ratio": 2,
  "kevlar_tuner_thumbnail_factor": 1,
  "kevlar_unified_player_logging_threshold": 1,
  "log_window_onerror_fraction": 0.1,
  "polymer_report_client_url_requested_rate": 0.001,
  "polymer_report_missing_web_navigation_endpoint_rate": 0.001,
  "prefetch_coordinator_error_logging_sampling_rate": 1,
  "tv_pacf_logging_sample_rate": 0.01,
  "web_shorts_error_logging_threshold": 0.001,
  "web_shorts_intersection_observer_threshold_override": 0,
  "web_system_health_fraction": 0.01,
  "ytidb_transaction_ended_event_rate_limit": 0.02,
  "ytidb_transaction_ended_event_rate_limit_session": 0.2,
  "ytidb_transaction_ended_event_rate_limit_transaction": 0.1,
  "autoplay_pause_by_lact_sec": 0,
  "autoplay_time": 8000,
  "autoplay_time_for_fullscreen": 3000,
  "autoplay_time_for_music_content": 3000,
  "botguard_async_snapshot_timeout_ms": 3000,
  "check_navigator_accuracy_timeout_ms": 0,
  "cinematic_watch_css_filter_blur_strength": 40,
  "cinematic_watch_fade_out_duration": 500,
  "client_streamz_web_flush_count": 100,
  "client_streamz_web_flush_interval_seconds": 60,
  "compression_performance_threshold": 250,
  "desktop_search_suggestion_tap_target": 0,
  "external_fullscreen_button_click_threshold": 2,
  "external_fullscreen_button_shown_threshold": 10,
  "get_async_timeout_ms": 60000,
  "high_priority_flyout_frequency": 3,
  "initial_gel_batch_timeout": 2000,
  "kevlar_mini_guide_width_threshold": 791,
  "kevlar_persistent_guide_width_threshold": 1312,
  "kevlar_time_caching_end_threshold": 15,
  "kevlar_time_caching_start_threshold": 15,
  "kevlar_tooltip_impression_cap": 2,
  "kevlar_tuner_default_comments_delay": 1000,
  "kevlar_tuner_scheduler_soft_state_timer_ms": 800,
  "kevlar_tuner_visibility_time_between_jobs_ms": 100,
  "kevlar_watch_flexy_metadata_height": 136,
  "kevlar_watch_metadata_refresh_description_lines": 3,
  "live_chat_chunk_rendering": 0,
  "log_web_meta_interval_ms": 0,
  "max_duration_to_consider_mouseover_as_hover": 600000,
  "max_prefetch_window_sec_for_livestream_optimization": 10,
  "min_mouse_still_duration": 100,
  "min_prefetch_offset_sec_for_livestream_optimization": 20,
  "minimum_duration_to_consider_mouseover_as_hover": 500,
  "mweb_history_manager_cache_size": 100,
  "network_polling_interval": 30000,
  "pacf_logging_delay_milliseconds_through_ybfe_tv": 0,
  "pbj_navigate_limit": -1,
  "polymer_log_prop_change_observer_percent": 0,
  "post_type_icons_rearrange": 1,
  "prefetch_comments_ms_after_video": 0,
  "prefetch_coordinator_command_timeout_ms": 60000,
  "prefetch_coordinator_max_inflight_requests": 1,
  "rich_grid_watch_open_animation_duration": 0,
  "send_config_hash_timer": 0,
  "service_worker_push_logged_out_prompt_watches": -1,
  "service_worker_push_prompt_cap": -1,
  "service_worker_push_prompt_delay_microseconds": 3888000000000,
  "shorts_inline_player_triggering_delay": 500,
  "user_engagement_experiments_rate_limit_ms": 86400000,
  "user_mention_suggestions_edu_impression_cap": 10,
  "visibility_time_between_jobs_ms": 100,
  "watch_next_pause_autoplay_lact_sec": 4500,
  "web_emulated_idle_callback_delay": 0,
  "web_foreground_heartbeat_interval_ms": 28000,
  "web_gel_debounce_ms": 10000,
  "web_home_feed_reload_delay": 1440,
  "web_inline_player_triggering_delay": 1000,
  "web_logging_max_batch": 150,
  "web_player_caption_language_preference_stickiness_duration": 0,
  "web_search_inline_player_triggering_delay": 500,
  "web_shorts_inline_playback_preview_ms": 0,
  "web_shorts_scrubber_threshold_sec": 0,
  "web_shorts_shelf_fixed_position": 9,
  "web_smoothness_test_duration_ms": 0,
  "web_smoothness_test_method": 0,
  "yoodle_end_time_utc": 0,
  "yoodle_start_time_utc": 0,
  "ytidb_remake_db_retries": 3,
  "ytidb_reopen_db_retries": 3,
  "WebClientReleaseProcessCritical__youtube_web_client_version_override": "",
  "debug_forced_internalcountrycode": "",
  "desktop_search_bigger_thumbs_style": "DEFAULT",
  "desktop_searchbar_style": "default",
  "embeds_web_synth_ch_headers_banned_urls_regex": "",
  "kevlar_duplicate_pref_cookie_domain_override": "",
  "kevlar_link_capturing_mode": "",
  "live_chat_unicode_emoji_json_url": "https://www.gstatic.com/youtube/img/emojis/emojis-svg-9.json",
  "polymer_task_manager_status": "production",
  "service_worker_push_force_notification_prompt_tag": "1",
  "service_worker_scope": "/",
  "web_client_version_override": "",
  "web_modern_subscribe_style": "filled",
  "web_searchbar_style": "rounded_corner_borders_light_btn",
  "web_shorts_expanded_overlay_type": "DEFAULT",
  "web_shorts_overlay_vertical_orientation": "bottom",
  "yoodle_base_url": "",
  "yoodle_webp_base_url": "",
  "conditional_lab_ids": [],
  "guide_business_info_countries": [
    "KR"
  ],
  "guide_legal_footer_enabled_countries": [
    "NL",
    "ES"
  ],
  "kevlar_command_handler_command_banlist": [],
  "kevlar_page_service_url_prefix_carveouts": [],
  "web_op_signal_type_banlist": []
}

WesselKroos commented 1 year ago

Sadly, that did not work. I'm wondering if I'll ever be able to reproduce it again or if that'll be a one time as well when it happens.

avi12 commented 1 year ago

I noticed that the issue occurs consistently when I transition from light mode to dark mode, but not vice versa

WesselKroos commented 1 year ago

Good to know. It doesn't happen for me when transitioning to both modes.

Could you check the following?

If it happens when you are logged out
If it happens in incognito mode and logged out
If it happens in another browser when you are logged in
If it happens in another browser when you are logged out

avi12 commented 1 year ago

Brave stable

Logged out without incognito: Happens
Logged out in incognito: Happens

Edge stable

Logged in: Doesn't happen
Logged out: Doesn't happen
Logged out in incognito: Doesn't happen

Chrome stable

Logged in: Doesn't happen
Logged out: Doesn't happen
Logged out in incognito: Doesn't happen

avi12 commented 1 year ago

Seems like it's a Brave-specific issue, despite being on the latest version, 1.48.167

WesselKroos commented 1 year ago

@avi12 Then it could be a specific setting or extension that you have in the Brave browser and not in the other browsers. Could you check if it is a specific browser setting or extension that you have enabled?

And because I cannot reproduce it in the Brave browser, I suspect that you could also install the Brave browser on another device to see what the differences are between your settings and the settings of a new installation of the Brave browser.

avi12 commented 1 year ago

I was just about to format the computer to get a clean Windows 10 installation as my Windows installation had plenty of issues

avi12 commented 1 year ago

Surprisingly, even after formatting and switching to Edge, I'm still getting this issue

WesselKroos commented 1 year ago

Strange, I still cannot even let the YouTube homepage switch between themes in Firefox, Edge, Chrome, Brave or Opera based on my Windows 10 or 11 theme without a manual page refresh.

WesselKroos commented 1 year ago

@avi12 Are you sure you didn't install extensions or unpacked personal extensions in Edge that you had previously in Brave?

avi12 commented 1 year ago

Extensions list:

P.S. Dark Reader and uBlock Origins are disabled for YouTube

WesselKroos commented 1 year ago

@avi12 Does it still happen when you disable all extensions and restart the browser?

avi12 commented 1 year ago

OK, I found the issue and it was not with your extension Apparently, I incorrectly configured Dark Reader to ignore YouTube After explicitly disabling on YouTube (and not just "disable when dark mode is detected on the site"), the problem was solved

avi12 commented 1 year ago

A possible way to solve the issue permanently is to add !important to the text colors

WesselKroos / youtube-ambilight