search

WesselKroos / youtube-ambilight

This browser extension adds ambient light to YouTube videos
MIT License
79 stars 8 forks source link

Ambilight Straight Up Not Working #153

Closed Desoroxxx closed 1 year ago

Desoroxxx commented 1 year ago

Describe the bug

Since a few days now ambilight just does not work, the setting icon in the YouTube bar is missing, and pressing A or any shortcuts does nothing.

To reproduce

Steps to reproduce the behavior:

  1. Go to any YouTube page
  2. It is not working
  3. Press A
  4. Still not working

Expected behavior

Well, ambilight working...

Screenshots

image

Desktop (please complete the following information):

Other extensions:

Ambilight does not work even with all extensions disabled

WesselKroos commented 1 year ago

@JustDesoroxxx This is probably the same issue as the crash that happens described in this issue: #152 To validate this you can open the javascript console (Press F12 > Open the "Console" tab) when the button has not shown up: TypeError: Cannot read properties of null (reading 'appendChild') in Settings.showWebGLCrashDescription

In case you see another error message, could you make a screenshot of the log messages in the console tab?

PS: Issue #152 is fixed in version 2.37.6 which was being reviewed by Microsoft. I just received an email that it has been published. I'm not seeing the new version in the Edge Add-Ons store yet, but it could be updated any minute/hour.

WesselKroos commented 1 year ago

@JustDesoroxxx Version 2.37.6 is now available in the Edge Add-ons store. Is the issue fixed for you in that version?

Desoroxxx commented 1 year ago

Yes, it is fixed!

Thanks for the super quick fix!

WesselKroos commented 1 year ago

@JustDesoroxxx Nice to hear that it has been fixed! However, it could be that you have disabled WebGL in the browser by yourself, then everything is fine. But it could also be that WebGL has crashed. In that case I would like to fix that issue, as WebGL can give you a significant performance boost (and for other users with the same problem).

If you are willing to help me out, could you check which error message is displayed under the "WebGL renderer" setting? You'll have to turn on the "Advanced" setting to see the "WebGL renderer" setting and the error message at this location: image

In case the error message starts with "Failed to load at ..." you can enable the "WebGL renderer" setting once, the page will then reload and the WebGL renderer will crash a single time. Now press the "F12" keyboard key to open a DevTools panel and select the "Console" tab: image Make a screenshot of the log messages that are displayed in the console. There could be an error or warning that indicates what the problem is and could help me fix the underlaying issue for you and others.

Desoroxxx commented 1 year ago

The extension was already using WebGL without giving any error in the setting menu. After verifying with https://get.webgl.org// and internal edge pages it seems that every WebGL feature is working as it should.

But I still turned off WebGL renderer and when the page reloaded turned it on and everything seems fine and here is the console: image

Though I am fairly sure Ambilight WebGL renderer is working correctly, as putting the Resolution up and down has a visual difference and the Resolution & draw time stats option give the same impression of it working.

Tell me if you need anything else

WesselKroos commented 1 year ago

Hmm... strange that it executed showWebGLCrashDescription previously. I guess something went wrong in a previous version of the extension causing it to trigger showWebGLCrashDescription.

I'm glad to hear that the WebGL renderer is working correctly again as well. Feel free to create another issue in case you ever get an error again, so for now enjoy the ambiance! 😃