WesselKroos / youtube-ambilight

This browser extension adds ambient light to YouTube videos
MIT License
79 stars 8 forks source link

Ambient light not visible in fullscreen #159

Closed WesselKroos closed 1 year ago

WesselKroos commented 1 year ago

Bug description

When going to fullscreen mode the ambient light is not visible

Steps to reproduce the behavior

  1. Go to fullscreen
  2. The ambient light disappeared

Browser

Chrome, Microsoft Edge, Opera, Firefox

Operating system

Windows, Apple macOS

Extension version

2.37.17

The bug still happens in these conditions

Additional context and/or screenshots

To workaround this you have to disable and re-enable it again. (Or logout from your YouTube account.)

This only happens when YouTube has applied certain experimental flags/settings to an account:

ShadyDOM.settings.noPatch === "on-demand"
ytcfg.get('EXPERIMENT_FLAGS').polymer_on_demand_shady_dom === true

To recreate this bug:

  1. set a breakpoint at the top of the javascript files webcomponents-sd.js and desktop_polymer.js
  2. When the webcomponents-sd.js breakpoint hits execute:
    ShadyDOM = {
    ...ShadyDOM,
    noPatch: "on-demand",
    }
  3. When the desktop_polymer.js breakpoint hits execute:
    ytcfg.set('EXPERIMENT_FLAGS', {
    ...ytcfg.get('EXPERIMENT_FLAGS'),
    polymer_on_demand_shady_dom: true
    })
WesselKroos commented 1 year ago

PS: Reported by @Nate-Zephyr