Buttons are displayed in the wrong theme when the ambient light theme is set to another value than YouTube's settings

WesselKroos / youtube-ambilight

This browser extension adds ambient light to YouTube videos

MIT License

78 stars 8 forks source link

Buttons are displayed in the wrong theme when the ambient light theme is set to another value than YouTube's settings #201

Closed avi12 closed 6 months ago

avi12 commented 8 months ago

Bug description

Incomplete dark/light mode

Steps to reproduce the behavior

Be logged in
Start from light/dark mode
Change to the opposite theme

Browser

Microsoft Edge

Operating system

Windows

Extension version

2.38.0

The bug still happens in these conditions

[X] The bug still persist when I disable all other extensions (ex. in incognito mode with only this extension enabled)
[ ] When I logged out of my YouTube account (ex. in incognito mode)
[ ] In incognito mode

Additional context and/or screenshots

Interestingly, when I either log out or open InPrivate (with the ext being the only one enabled), the bug is resolved Note that I'm on Edge but running the CWS extension

WesselKroos commented 8 months ago

It seems like they have introduced some theme changes with their new live counters

avi12 commented 8 months ago

Huh, very interesting Let me know if you have a hotfix and you want me to try out a version before you release it to the stores

WesselKroos commented 8 months ago

It should be solved in this beta version: youtube-ambilight-v2.38.0.1.zip

avi12 commented 8 months ago

I tried to set when I do, it briefly switches to light theme and then back to dark theme

WesselKroos commented 8 months ago

I tried to set ... when I do, it briefly switches to light theme and then back to dark theme

So it works?

avi12 commented 8 months ago

https://github.com/WesselKroos/youtube-ambilight/assets/6422804/27260a12-327a-4cd6-a376-874856186e73

WesselKroos commented 8 months ago

What theme have you set in the Ambient light settings?

PS: This is also just a bug without the ambient light caused by YouTube's style on these buttons. So I've reported this bug to YouTube as well:

avi12 commented 8 months ago

What theme have you set in the Ambient light settings?

Just the defaults; I sideloaded the extension, opened a video and the result is in the screen recording

avi12 commented 8 months ago

Notice how in the main post I mentioned that in the production version I only reproduce the bug when I'm logged into YouTube but when I'm not then I do not reproduce it

WesselKroos commented 8 months ago

What theme have you set in the Ambient light settings?

Just the defaults; I sideloaded the extension, opened a video and the result is in the screen recording

Then it works correctly. The YouTube theme is restored to dark theme when the theme is set to the dark theme in the extension.

Notice how in the main post I mentioned that in the production version I only reproduce the bug when I'm logged into YouTube but when I'm not then I do not reproduce it

I'm also logged in and have fixed the same color issues in that test version. Can you send me a screenshot of the wrong button colors with this test version?

avi12 commented 8 months ago

After setting the theme to Default, it behaves as expected

Can you send me a screenshot of the wrong button colors with this test version?

Everything seems to be in the right color, as far as I can tell