search

WesselKroos / youtube-ambilight

This browser extension adds ambient light to YouTube videos
MIT License
78 stars 8 forks source link

Switch settings per system/OS dark/light theme #221

Open ovojake opened 4 months ago

ovojake commented 4 months ago

During daytime I prefer to disable ambient light while still keeping the black bars disabled in theatre mode, while at night I like having ambient light on- I find it looks much better in dark mode while its a bit distracting in light mode. Right now I just turn off blur and spread while in light mode, but it would be nice to save those configurations to change when switching to dark mode, and vice versa. Not sure how easy it would be to implement but its not a big deal if you don't want to do this.

WesselKroos commented 4 months ago

Thanks for the suggestion.

Day- and nighttime are vague terms, could you clarify what you mean by those. I can think of a switch that triggers:

  1. when the System/OS theme toggles between dark/light
  2. or when a specific morning-/evening times are reached

But I think you are hinting at option 1?

I believe your feature request is similar to #9. The only difference would be what triggers the switch between configurations.

I've been experimenting with several ways how this could work, but not every setting is changeable on the fly at the moment, so this will take me some more work to get done. To make things less complex I'm thinking of first targetting a version that makes it possible to manually switch between configurations, optionally via a hotkey(s). Then later we can work out which ways to trigger configuration switches and make those manageable via some settings.

ovojake commented 4 months ago

Hey, thanks for getting back to me.

Option 1 could be nice to have. During daytime my OS is set to light mode, and I find myself turning off "blur" and "spread" until night when my OS switches back to dark mode. I just thought that if there was a way to tell the extension to disable blur and spread automatically when switching to lightmode, it might be a small QoL improvement.

Basically in the daytime (lightmode), I only use this extension to remove the black bars in theatre mode.

On Thu, 29 Feb 2024 at 11:19, Wessel Kroos @.***> wrote:

Thanks for the suggestion.

Day- and nighttime are vague terms, could you clarify what you mean by those. I can think of a switch that triggers:

  1. when the System/OS theme toggles between dark/light
  2. or when a specific morning-/evening times are reached But I think you are hinting at option 1?

I believe your feature request is similar to #9 https://github.com/WesselKroos/youtube-ambilight/issues/9. The only difference would be what triggers the switch between configurations.

I've been experimenting with several ways how this could work, but not every setting is changeable on the fly at the moment, so this will take me some more work to get done. To make things less complex I'm thinking of first targetting a version that makes it possible to manually switch between configurations, optionally via a hotkey(s). Then later we can work out which ways to trigger configuration switches and make those manageable via some settings.

— Reply to this email directly, view it on GitHub https://github.com/WesselKroos/youtube-ambilight/issues/221#issuecomment-1971805243, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGHW22UMJLO3WEAWUFV6PZ3YV57NHAVCNFSM6AAAAABDSJU7AOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRHAYDKMRUGM . You are receiving this because you authored the thread.Message ID: @.***>