search

WesselKroos / youtube-ambilight

This browser extension adds ambient light to YouTube videos
MIT License
87 stars 8 forks source link

Ambient Light Stops Rendering in full-screen mode on Ultrawide Screen #227

Closed tshih5 closed 8 months ago

tshih5 commented 8 months ago

Troubleshooter First try all the checks and steps in the troubleshooter: https://github.com/WesselKroos/youtube-ambilight/blob/master/TROUBLESHOOT.md

  1. Did it solve your performance problems? No
  2. What steps made it worse/better: Not much change with different settings

Describe the performance you are currently experiencing

  1. No issues performance wise other than the fullscreen issue.

Device information

  1. Name of your CPU: Ryzen 7 7700X

  2. Name of your GPU: Nvidia RTX 2070S

  3. Name of the browser: Firefox

  4. Version of the browser: 124.0 Screenshots

  5. Add a screenshot of the Task manager with the CPU and GPU usage charts Full Screen with video playing (Ambient Light is frozen) image Full Screen with video playing (Ambient Light is playing) image

  6. Turn on the Ambient light setting Quality > Show framerate and make a screenshot of your framerates In theater mode with ambient light playing image Full Screen mode (ambient light is frozen) (Bar graph also seems to stop moving) image

Describe the performance you would be happy with

  1. N/A

Describe any workaround you've tried so far

  1. Turning on Bar size or changing the video size off of 100% causes rendering to resume, however the video gets cropped. Scrolling down on the video in full screen mode causes ambient light to resume.

Additional context Add any other context or screenshots about the feature request here. Additonal Images: Video playing in full screen, ambient light does not play image Scrolling down, in full screen mode, ambient light starts playing image

WesselKroos commented 8 months ago
  1. Turning on Bar size or changing the video size off of 100% causes rendering to resume, however the video gets cropped. Scrolling down on the video in full screen mode causes ambient light to resume.

Strange, this hints at the extension thinking that the video is filling the width of you screen (which is obviously not the case). Causing it to pauze the ambilight light to save power.

  1. Is the framerate of the ambilight light in the stats 1 fps when you enable horizontal or vertical bar detection?

  2. What is the width of the <video src="..." /> element in the html? Does it fill the width of your screen?

  3. What other extensions / Add-ons are you using?

tshih5 commented 8 months ago
  1. By Vertical/Horizontal bar detection I'm assuming you mean "Remove Black Bars" for the Remove black & colored section. When that setting is checked, it is saying that it is a 30FPS (which is what I have it set to in the Quality menu image image
  2. the video is 3440x1440, which is the size of my monitor
  3. Here are the extensions I am using image

I think i found the issue! UltraWideo was the culprit, turning it off made ambient light play properly again. Not sure why exactly having that extension on broke the extension (It's also a video manipulation extension), but it is what it is. Thanks for looking into it though. Cheers :D

WesselKroos commented 8 months ago

...UltraWideo was the culprit, turning it off made ambient light play properly again. Not sure why exactly having that extension on broke the extension...

Aha. In that case UltraWide was stretching the video element to the width of your monitor. Which makes the Ambient light think that the video fills your screen and thus there was no need to draw the ambient light.