Disabled buttons aren't colored correctly

WesselKroos / youtube-ambilight

This browser extension adds ambient light to YouTube videos

MIT License

87 stars 8 forks source link

Disabled buttons aren't colored correctly #243

Closed avi12 closed 5 months ago

avi12 commented 6 months ago

Bug description

Disabled buttons aren't colored correctly

Steps to reproduce the behavior

https://www.youtube.com/watch?v=cev4185JuF8

Browser

Microsoft Edge

Operating system

Windows

Extension version

2.38.7

The bug still happens in these conditions

[ ] The bug still persist when I disable all other extensions (ex. in incognito mode with only this extension enabled)
[ ] When I logged out of my YouTube account (ex. in incognito mode)
[ ] In incognito mode

Additional context and/or screenshots

In this case, it's a video labeled for kids

WesselKroos commented 5 months ago

Thanks for the heads-up. Can you tell me how I can get that disabled button? Because I don't have that disabled button, even in incognito (logged out) it's enabled and clicking it displays a popup:

avi12 commented 5 months ago

When I clicked the Share button it didn't let me share the video because it is "kids friendly"

WesselKroos commented 5 months ago

My share button is not disabled on a kids friendly video

avi12 commented 5 months ago

https://github.com/WesselKroos/youtube-ambilight/assets/6422804/cd1459a4-93dc-4e4a-89a1-a6a1e2724430

WesselKroos commented 5 months ago

Got it, I had to login.

YouTube light:

YouTube light + Ambient light:

YouTube light + Ambient dark:

YouTube dark:

YouTube dark + Ambient light:

YouTube dark + Ambient dark:

Todo:

[x] Override the selector: .yt-spec-button-shape-next--disabled.yt-spec-button-shape-next--tonal
[x] Change the gray text color on a disabled button to semi transparent black/white
[x] Change the background color of a disabled button to semi transparent black/white

WesselKroos commented 5 months ago

Changed disabled buttons styling to:

Ambient dark:

Ambient light: