WesselKroos / youtube-ambilight

This browser extension adds ambient light to YouTube videos
MIT License
87 stars 8 forks source link

Settings reset after each update #259

Closed Luke0094 closed 2 months ago

Luke0094 commented 2 months ago

Bug description

As title, after each update settings are lost and need to be loaded again, this is especially noticeable with black bar since is still an experimental feature that might cut partially the video.

Steps to reproduce the behavior

As above.

Browser

Chrome

Operating system

Windows

Extension version

2.38.10

The bug still happens in these conditions

Additional context and/or screenshots

image image
WesselKroos commented 2 months ago

I'm unable to reproduce this issue. The extension data is coupled to your browser's extension storage, so I'm not doing anything special to migrate these settings.

Could you clarify:

  1. When this happend
  2. From which to which extension version update this happend
  3. If possible, create a screenrecording of the settings being reset after an update
Luke0094 commented 2 months ago

This happen quite frequently since the first time I've installed the extensions (been a while now), not sure if is about update, cache cleaning or what then however I have no problem with all other my extensions, just this one that apparently every few weeks looses settings, the only reason I'm noticing this issue is cause the "remove black bar" that happen to be again enabled, I'm not even sure if looses all settings or just this particular one. I apologize if I'm unable to provide more clarifications.

WesselKroos commented 2 months ago

Maybe you're often switching account's/signin out/logging back into your Google Chrome account. You can use the import from/export to cloud storage feature to save and restore your settings:

image

Luke0094 commented 2 months ago

Ar, i'll check with this setting.

Btw yes, it might be the issue then, i use multiple google accounts hower like I've said before didn't had any of these problems with other extensions.

WesselKroos commented 2 months ago

Could you give some extensions for which you have not had this problem?

Luke0094 commented 2 months ago

For exemple Enhancer for YouTube, SponsorBlock per YouTube, AdGuard and Dark Reader that all uses stored settings. The only thing I can think is that AdGuard with his settings may delete cookies ineherent also to this extensions but is weird.

WesselKroos commented 2 months ago

Strange, they also use the same storage api.

There is also a reset-all-settings button in the top right of the menu. But I doubt that you've clicked that button, since it pops up a confirmation dialog before deleting all your settings. image

So I'm not sure how I could help you further with this issue to be honest. Is it ok if I close this issue until you've found the steps to reproduce it (or when more users report this problem)?

Luke0094 commented 2 months ago

It's ok you can close it, is an unfortunate issue, since is a random behavior not sure what i can do on my part.