WestHealth / pyvis

Python package for creating and visualizing interactive network graphs.
http://pyvis.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
940 stars 162 forks source link

fixes #276 #277

Open norweeg opened 3 months ago

norweeg commented 3 months ago
norweeg commented 3 months ago

general comment: I found the code rife with inappropriate and unsafe usage of assert as control logic/type checking. That should be completely refactored out because this library will fail spectacularly if run when __debug__ is False such as when running the interpreter with the -O flag or if the environment variable PYTHONOPTIMIZE is set

https://snyk.io/blog/the-dangers-of-assert-in-python/