WestRidgeSystems / jmisb

jMISB is an open source Java library implementing various MISB standards.
MIT License
41 stars 12 forks source link

chore: upgrade slf4j to 2.0.1 #421

Closed bradh closed 2 years ago

bradh commented 2 years ago

Motivation and Context

SLF4J facade has just reached 2.0.1. This upgrades jmisb 2.x to use that.

There is a knock-on change to some of the module requires, and requires a different log4j implementation and a different slf4jtest implementation to deal with the changes.

Description

Updates version in manage dependencies, modifies viewer dependencies, and adds module imports.

Test version is upgraded - requires different imports for namespace changes.

How Has This Been Tested?

Unit tested.

Ran viewer application with test sample that generates log results. Checked OK.

Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Base: 91.03% // Head: 91.03% // No change to project coverage :thumbsup:

Coverage data is based on head (c8530a1) compared to base (bf0c3c3). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x #421 +/- ## ========================================= Coverage 91.03% 91.03% Complexity 5610 5610 ========================================= Files 610 610 Lines 14571 14571 Branches 1379 1379 ========================================= Hits 13265 13265 Misses 1269 1269 Partials 37 37 ``` | Flag | Coverage Δ | | |---|---|---| | unittests-api | `98.67% <ø> (ø)` | | | unittests-api-ffmpeg | `15.85% <ø> (ø)` | | | unittests-awt | `100.00% <ø> (ø)` | | | unittests-core | `98.44% <ø> (ø)` | | | unittests-geoid | `100.00% <ø> (ø)` | | | unittests-mimd | `97.24% <ø> (ø)` | | | unittests-st0601 | `99.26% <ø> (ø)` | | | unittests-st0602 | `99.06% <ø> (ø)` | | | unittests-st0805 | `99.17% <ø> (ø)` | | | unittests-st0806 | `99.64% <ø> (ø)` | | | unittests-st0808 | `99.08% <ø> (ø)` | | | unittests-st0809 | `99.11% <ø> (ø)` | | | unittests-st0903-vmti | `98.79% <ø> (ø)` | | | unittests-st0903-vtrack | `97.09% <ø> (ø)` | | | unittests-st1108 | `99.66% <ø> (ø)` | | | unittests-st1206 | `99.59% <ø> (ø)` | | | unittests-st1301 | `98.91% <ø> (ø)` | | | unittests-st1403 | `100.00% <ø> (ø)` | | | unittests-st1601 | `100.00% <ø> (ø)` | | | unittests-st1602 | `100.00% <ø> (ø)` | | | unittests-st1603 | `98.03% <ø> (ø)` | | | unittests-st1909 | `99.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bradh commented 2 years ago

Note: this is still WIP pending a version of log4j2 that works with slf4j 2.0.0 or later. See https://github.com/apache/logging-log4j2/pull/1025

bradh commented 2 years ago

The log4j2 implementation has been released (at 2.19.0). See https://github.com/apache/logging-log4j2/blob/release-2.x/RELEASE-NOTES.md#apache-log4j-2190-release-notes