WestRidgeSystems / jmisb

jMISB is an open source Java library implementing various MISB standards.
MIT License
41 stars 12 forks source link

Bump ffmpeg-platform so build succeeds on ARM macOS machines #448

Closed lannybroo closed 1 year ago

lannybroo commented 1 year ago

Describe the bug Running mvn install on a fresh clone of jMISB fails on macOS ARM machine.

To Reproduce Steps to reproduce the behavior:

  1. git clone https://github.com/WestRidgeSystems/jmisb.git on an ARM macOS machine
  2. Run mvn install (I was on the main branch which was on release 1.12)
  3. Error during test suite execution was java.lang.UnsatisfiedLinkError: no jnijavacpp in java.library.path and eventually in org.jmisb.core.video.FrameConverterTest.convertCheck which reports java.lang.RuntimeException: No native JavaCPP library in memory

Expected behavior The build should succeed.

Configuration (please complete the following information):

Additional context I was able to successfully build by bumping the version of ffmpeg-platform in the main pom.xml from 4.3.1-1.5.4 to 5.1.2-1.5.8, like so:

diff --git a/pom.xml b/pom.xml
index 1d9d8d58..f18d117a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -102,7 +102,7 @@
             <dependency>
                 <groupId>org.bytedeco</groupId>
                 <artifactId>ffmpeg-platform</artifactId>
-                <version>4.3.1-1.5.4</version>
+                <version>5.1.2-1.5.8</version>
             </dependency>
         </dependencies>
     </dependencyManagement>
bradh commented 1 year ago

Seems reasonable. Do you want to make PRs against main and 2.x branches for this?

lannybroo commented 1 year ago

Seems reasonable. Do you want to make PRs against main and 2.x branches for this?

Sure. Will do.

Except I found that the 2.x branch as of b7c127c4c20ec2c35e86d0748315d8ed1711580b builds cleanly, so I will only do a PR for main. It looks like 2.x already points to ffmpeg-platform version 5.1.2-1.5.8.