WestRidgeSystems / jmisb

jMISB is an open source Java library implementing various MISB standards.
MIT License
41 stars 12 forks source link

st1601: fix missing @Test annotations #449

Closed bradh closed 1 year ago

bradh commented 1 year ago

Motivation and Context

During work on another local set, I noticed that there was a broken test in ST 1601 (i.e. it couldn't have passed). That wasn't being run, because it was missing the @Test annotation. Several other unit tests in the same test class were also missing that annotation.

The original version of this PR failed dependency checks for https://nvd.nist.gov/vuln/detail/CVE-2021-4277 which is completely unrelated to anything we use - its a broken NVD entry. There is an updated version of the OWASP dependency check plugin that suppresses that entry. Upgrading also brought in a fix for a previous false positive (https://github.com/jeremylong/DependencyCheck/issues/5121) and we no longer need our own suppression for that.

Description

Added missing annotations and fix the broken test. There is no code changes - this only affects the tests.

Update dependency check plugin and remove redundant suppression.

How Has This Been Tested?

Full build, including the dependencycheck profile.

Screenshots (if appropriate):

Types of changes

Checklist:

codecov-commenter commented 1 year ago

Codecov Report

Base: 90.31% // Head: 91.79% // Increases project coverage by +1.47% :tada:

Coverage data is based on head (ae48086) compared to base (aaa1206). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.x #449 +/- ## ============================================ + Coverage 90.31% 91.79% +1.47% - Complexity 5684 5736 +52 ============================================ Files 619 619 Lines 14934 14934 Branches 1424 1424 ============================================ + Hits 13488 13709 +221 + Misses 1405 1154 -251 - Partials 41 71 +30 ``` | Flag | Coverage Δ | | |---|---|---| | unittests-api | `98.39% <ø> (ø)` | | | unittests-api-ffmpeg | `31.49% <ø> (+15.64%)` | :arrow_up: | | unittests-awt | `98.60% <ø> (ø)` | | | unittests-core | `98.44% <ø> (ø)` | | | unittests-geoid | `100.00% <ø> (ø)` | | | unittests-mimd1 | `91.17% <ø> (ø)` | | | unittests-mimd2 | `85.36% <ø> (ø)` | | | unittests-mimdbase | `100.00% <ø> (ø)` | | | unittests-st0601 | `99.26% <ø> (ø)` | | | unittests-st0602 | `77.64% <ø> (ø)` | | | unittests-st0805 | `99.17% <ø> (ø)` | | | unittests-st0806 | `99.64% <ø> (ø)` | | | unittests-st0808 | `99.08% <ø> (ø)` | | | unittests-st0809 | `99.11% <ø> (ø)` | | | unittests-st0903-vmti | `98.75% <ø> (ø)` | | | unittests-st0903-vtrack | `97.09% <ø> (ø)` | | | unittests-st1108 | `99.66% <ø> (ø)` | | | unittests-st1206 | `99.59% <ø> (ø)` | | | unittests-st1301 | `98.91% <ø> (ø)` | | | unittests-st1403 | `100.00% <ø> (ø)` | | | unittests-st1601 | `100.00% <ø> (ø)` | | | unittests-st1602 | `100.00% <ø> (ø)` | | | unittests-st1603 | `98.03% <ø> (ø)` | | | unittests-st1909 | `99.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/WestRidgeSystems/jmisb/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | Coverage Δ | | |---|---|---| | [...src/main/java/org/jmisb/api/video/FfmpegUtils.java](https://codecov.io/gh/WestRidgeSystems/jmisb/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems#diff-YXBpLWZmbXBlZy9zcmMvbWFpbi9qYXZhL29yZy9qbWlzYi9hcGkvdmlkZW8vRmZtcGVnVXRpbHMuamF2YQ==) | `14.89% <0.00%> (+4.25%)` | :arrow_up: | | [...src/main/java/org/jmisb/api/video/VideoOutput.java](https://codecov.io/gh/WestRidgeSystems/jmisb/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems#diff-YXBpLWZmbXBlZy9zcmMvbWFpbi9qYXZhL29yZy9qbWlzYi9hcGkvdmlkZW8vVmlkZW9PdXRwdXQuamF2YQ==) | `47.12% <0.00%> (+47.12%)` | :arrow_up: | | [...g/src/main/java/org/jmisb/api/video/FfmpegLog.java](https://codecov.io/gh/WestRidgeSystems/jmisb/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems#diff-YXBpLWZmbXBlZy9zcmMvbWFpbi9qYXZhL29yZy9qbWlzYi9hcGkvdmlkZW8vRmZtcGVnTG9nLmphdmE=) | `64.70% <0.00%> (+52.94%)` | :arrow_up: | | [...ain/java/org/jmisb/api/video/OutputStatistics.java](https://codecov.io/gh/WestRidgeSystems/jmisb/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems#diff-YXBpLWZmbXBlZy9zcmMvbWFpbi9qYXZhL29yZy9qbWlzYi9hcGkvdmlkZW8vT3V0cHV0U3RhdGlzdGljcy5qYXZh) | `54.54% <0.00%> (+54.54%)` | :arrow_up: | | [...in/java/org/jmisb/api/video/VideoStreamOutput.java](https://codecov.io/gh/WestRidgeSystems/jmisb/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems#diff-YXBpLWZmbXBlZy9zcmMvbWFpbi9qYXZhL29yZy9qbWlzYi9hcGkvdmlkZW8vVmlkZW9TdHJlYW1PdXRwdXQuamF2YQ==) | `63.90% <0.00%> (+63.90%)` | :arrow_up: | | [.../src/main/java/org/jmisb/api/video/CodecUtils.java](https://codecov.io/gh/WestRidgeSystems/jmisb/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems#diff-YXBpLWZmbXBlZy9zcmMvbWFpbi9qYXZhL29yZy9qbWlzYi9hcGkvdmlkZW8vQ29kZWNVdGlscy5qYXZh) | `95.83% <0.00%> (+95.83%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.