fix: FrameConverter only copies upper square on portrait-format video

lannybroo commented 6 months ago

FrameConverter should be copying lines for the height of the image, not the width. Width happened to work since most test videos are landscape.

Motivation and Context

Portrait videos do not play properly, only rendering the upper (width x width) part of the video.

Description

The change is a one-line fix in the FrameConverter's convert method where a decoded frame is put into a ByteBuffer.

How Has This Been Tested?

Tested on a few different portrait-format videos I had handy and on a set of landscape video I usually work with. Not extensively tested.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.84%. Comparing base (d05758b) to head (3aa5182).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 2.x #460 +/- ## ========================================= Coverage 90.84% 90.84% Complexity 6068 6068 ========================================= Files 660 660 Lines 15876 15876 Branches 1515 1515 ========================================= Hits 14422 14422 Misses 1410 1410 Partials 44 44 ``` | [Flag](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | Coverage Δ | | |---|---|---| | [unittests-api](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `98.39% <ø> (ø)` | | | [unittests-api-ffmpeg](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `15.85% <100.00%> (ø)` | | | [unittests-awt](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `98.60% <ø> (ø)` | | | [unittests-core](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `98.44% <ø> (ø)` | | | [unittests-geoid](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `100.00% <ø> (ø)` | | | [unittests-mimd1](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `91.17% <ø> (ø)` | | | [unittests-mimd2](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `85.36% <ø> (ø)` | | | [unittests-mimdbase](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `100.00% <ø> (ø)` | | | [unittests-st0601](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `99.30% <ø> (ø)` | | | [unittests-st0602](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `77.64% <ø> (ø)` | | | [unittests-st0805](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `99.17% <ø> (ø)` | | | [unittests-st0806](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `99.64% <ø> (ø)` | | | [unittests-st0808](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `99.08% <ø> (ø)` | | | [unittests-st0809](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `99.11% <ø> (ø)` | | | [unittests-st0903-vmti](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `98.75% <ø> (ø)` | | | [unittests-st0903-vtrack](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `97.09% <ø> (ø)` | | | [unittests-st1002](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `98.95% <ø> (ø)` | | | [unittests-st1010](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `98.55% <ø> (ø)` | | | [unittests-st1108](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `99.66% <ø> (ø)` | | | [unittests-st1202](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `100.00% <ø> (ø)` | | | [unittests-st1206](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `99.59% <ø> (ø)` | | | [unittests-st1301](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `98.91% <ø> (ø)` | | | [unittests-st1403](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `100.00% <ø> (ø)` | | | [unittests-st1601](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `100.00% <ø> (ø)` | | | [unittests-st1602](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `100.00% <ø> (ø)` | | | [unittests-st1603](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `98.03% <ø> (ø)` | | | [unittests-st1909](https://app.codecov.io/gh/WestRidgeSystems/jmisb/pull/460/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems) | `99.65% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=WestRidgeSystems#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bradh commented 6 months ago

Looks like the QA failure is unrelated. Have proposed fix at #461.

WestRidgeSystems / jmisb