Swiping up or down while tabs animation could be mistaken for horizontal gestures

[sallychung]

Device: iPhone 6 Version: 1.0.104

Steps to reproduce:

1. Go to Ventilation/PPE
2. Swipe left
3. Before the animation finishes on Pre-oxygenation, swipe up

Expected: Pre-oxygenation screen should scroll up

Actual: Tab is shifted back to PPE

Video on Slack https://gdganz.slack.com/files/U9VUTTKSR/F011GPLQJE5/img_1348-480.mov

[lukesleeman]

I'm seeing this in Android as well. I'm wondering if its something fundamentally wrong with the flutter widgets. I think if this isn't something we easily fix, the best solution might be to just open a bug with upstream and live with it.

[workerbee22]

@sallychung and @lukesleeman watched the video and tried again and I can no longer replicate this issue on later versions.

Can you pleas re-test, but note the swipe up won't work until the tab transition is complete.

But I'm not seeing the swipe up causing mid tab transition, being mistaken for a horizontal gesture anymore.

So I'm also changing to Version 1.1 milestone at this stage, so even if still present seems minor?

[lukesleeman]

Yeah, I think we are fine to tag this v1.1

Perhaps it may be fixed by the flutter version upgrade?

[workerbee22]

Seems to be gone already ... but look more closely for 1.1

On Sat, 2 May 2020, 10:49 am Luke Sleeman, notifications@github.com wrote:

Yeah, I think we are fine to tag this v1.1

Perhaps it may be fixed by the flutter version upgrade?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Western-Health-Covid19-Collaboration/wh_covid19_app/issues/204#issuecomment-622640331, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHKO2ARAA3J7V7ORBMVZULRPNUZTANCNFSM4MDBYNLA .

[lukesleeman]

Tested and it still seems to be happening, but I guess this is something to do with flutter