Fix for info icon not showing ripple

Western-Health-Covid19-Collaboration / wh_covid19_app

Volunteer developed app containing information for frontline medical staff around COVID-19

29 stars 8 forks source link

Fix for info icon not showing ripple #308

Closed lukesleeman closed 4 years ago

lukesleeman commented 4 years ago

This fixes issue #305 - I have no idea what I'm doing with flutter but I had a look at how the call button was done, and copied that!

Hopefully this doesn't break anything 🤷‍♂️

Changes

Replace gesture detector with IconButton to gain ripple effect

Screenshots

ripple

Things to note

I don't know what I'm doing 🙃

workerbee22 commented 4 years ago

Actually @lukesleeman there is a better fix.

But on closer look it seems fine, but might optimise a little ... looking closer now.

workerbee22 commented 4 years ago

@lukesleeman Your change was fine 👍 but I did a little more cleanup of the code. Would like to do more but it has wider implications and so should wait for bigger changes post version 1.