search

Western-Health-Covid19-Collaboration / wh_covid19_app

Volunteer developed app containing information for frontline medical staff around COVID-19
29 stars 8 forks source link

Multiple Copy changes in Intubation guide #309

Closed greggmiller closed 4 years ago

greggmiller commented 4 years ago

Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-01 at 12 16 06 Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-01 at 12 16 03 ![Uploading Simulator Screen Shot - iPhone 11 Pro Max - 2020-05-01 at 12.16.00.png…]()

Major copy changes to reflect mos recent guidelines. Removal of multiple emojis and replaced with bullet points. This leaves some section quite lifeless compared to before so I am open to suggestions on this.

☝️ Provide a short & descriptive title for this PR.

Provide a more detailed summary of the changes in this PR here. What does it do?

Changes

Screenshots

If your PR changes anything visual please paste in some screenshots of the app here. Make sure you are working off the designs in zeplin. If your PR makes some significant visual tweaks feel free to include one of the designers as a reviewer, so they can check off and comment on what is changing.

Things to note

Include anything else the other Devs or Designers on the project should know? Will there be work you are deferring now, which done in later follow up PRs? Does this change anything about the code base they need to be aware of?

workerbee22 commented 4 years ago

@greggmiller yeah I have to say bullets with bullets doesn't look great. Is this temporary ? Because I thought you were going to pick new emojis based on @sallychung list of good emojis to use?

greggmiller commented 4 years ago

Yeah I’m happy for emojis and to amend 👍 I just didn’t have time today. I only had an hour window.

workerbee22 commented 4 years ago

👍

On Fri, 1 May 2020, 6:22 pm greggmiller, notifications@github.com wrote:

Yeah I’m happy for emojis and to amend 👍 I just didn’t have time today. I only had an hour window.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/Western-Health-Covid19-Collaboration/wh_covid19_app/pull/309#issuecomment-622297281, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHKO2CXXGMA74A2HQ57CHLRPKBFTANCNFSM4MWZTPGA .

workerbee22 commented 4 years ago

Yeah I’m happy for emojis and to amend 👍 I just didn’t have time today. I only had an hour window.

@greggmiller Then we won't merge this PR yet, until you get a chance to change the bullets to one of the 'safe' emojis from @sallychung

lukesleeman commented 4 years ago

Actually, I was going to try my hand at picking some emoji. I would suggest the following:

  1. Merge this PR - the bullets are at least an improvement to the ✅ if we don't manage to get anything else in.
  2. I'll create a new PR with some suggested emoji
  3. Greg can review my PR and make suggestions, etc based on that.

What do we think?